| Summary: | x11-terms/evilvte should use savedconfig.eclass for user config handling | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | James Rowe <jnrowe> |
| Component: | New packages | Assignee: | Desktop Misc. Team <desktop-misc> |
| Status: | VERIFIED FIXED | ||
| Severity: | minor | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
evilvte-0.4.5_pre2-use_savedconfig.patch
evilvte-use_savedconfig-for_older_ebuilds.patch |
||
Created attachment 190372 [details, diff]
evilvte-0.4.5_pre2-use_savedconfig.patch
I've added a pkg_postinst() notice because all the other packages using
savedconfig do, but it seems a little redundant because save_config() already
issues one. Maybe pkg_postinst() shouldn't?
Created attachment 190373 [details, diff]
evilvte-use_savedconfig-for_older_ebuilds.patch
This is just the same set of changes rebased for the 0.4.3 and
0.4.4_pre9 ebuilds, because if the change was made to the older ebuilds
the 0.4.5_pre2 patch needs mangling.
Should be fixed with latest now. |
There is already an in-tree solution for handling user editable config files -- savedconfig -- and it provides more functionality than the current evilvte method. Personally, I'd like to the change to using savedconfig because it respects ${PORTAGE_CONFIGROOT} and allows me to keep a different config per arch. [I'm abusing the arch difference locally to change host, not arch, specific settings... but it works with savedconfig ;)] I'm not convinced the upgrade path from the current code is as clean as it could be, but I can't see a better way around it which I think is another reason why the savedconfig route is better. I don't think it should cause problems though. It used the old /etc/evilvte/config.h file on upgrade to a savedconfig version, but removal won't happen if the user has edited it because of $CONFIG_PROTECT which would break the next upgrade unless it is forcibly removed. I've been overly careful with the removal, just the file and then the hopefully empty directory but I'm really interested in comments how it could be done better. Thanks, James Reproducible: Always