| Summary: | net-libs/libproxy-0.2.3: Poor programming practices | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | New packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | Keywords: | Inclusion |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://code.google.com/p/libproxy/issues/detail?id=47 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | libproxy-0.2.3-fix-implicit-declaration.patch | ||
Created attachment 190279 [details, diff]
libproxy-0.2.3-fix-implicit-declaration.patch
good to go. commited without a bump. Please make sure this reaches upstream as well. Thanks for your report. thanks. |
net-libs/libproxy-0.2.3 uses implicitly declared function strdup() which causes: * QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * proxy.c:50: warning: implicit declaration of function ‘strdup’ From string.h: #if defined __USE_SVID || defined __USE_BSD || defined __USE_XOPEN_EXTENDED /* Duplicate S, returning an identical malloc'd string. */ extern char *strdup (__const char *__s) __THROW __attribute_malloc__ __nonnull ((1)); #endif As you can see, strdup() returns 'char *', but compiler treats all implicitly declared functions as returning 'int'. It will cause segmentation fault on 64-bit architectures where sizeof(pointer) != sizeof(int).