Bug 267639

Summary:	games-misc/bsd-games-2.17-r2 building fails, broken source?
Product:	Gentoo Linux	Reporter:	Łukasz Stelmach <stlman>
Component:	Current packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	High
Version:	2007.0
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	the build log the environment the patch

Description Łukasz Stelmach 2009-04-27 09:36:22 UTC

Attempt to build bsd-games fails with a message about an error in one of the header files:

g++ -march=nocona -O2 -pipe -Wall -W -Wpointer-arith -Wcast-align -Wcast-qual -Wwrite-strings    -Iinclude   -Idab  -c dab/board.cc -o dab/board.o
In file included from dab/board.cc:49:
dab/gamescreen.h:73: error: multiple parameters named ‘p’
dab/gamescreen.h:74: error: multiple parameters named ‘p’
dab/gamescreen.h:75: error: multiple parameters named ‘p’
dab/board.cc: In member function ‘int BOARD::full() const’:
dab/board.cc:157: warning: cast from type ‘const BOARD*’ to type ‘BOARD*’ casts away constness
dab/board.cc: In member function ‘void BOARD::paint() const’:
dab/board.cc:176: warning: cast from type ‘const BOARD*’ to type ‘BOARD*’ casts away constness
make: *** [dab/board.o] Błąd 1


Reproducible: Always

Steps to Reproduce:
1. emerge bsd-games

Actual Results:  
fail

Expected Results:  
success

Comment 1 Łukasz Stelmach 2009-04-27 09:37:49 UTC

Created attachment 189598 [details]
the build log

Comment 2 Łukasz Stelmach 2009-04-27 09:38:11 UTC

Created attachment 189599 [details]
the environment

Comment 3 Łukasz Stelmach 2009-04-27 09:38:54 UTC

Created attachment 189601 [details, diff]
the patch

the patch changes names of the parameters in the header file.

Comment 4 Sebastian Luther (few) 2009-04-27 10:11:30 UTC

This is already fixed in =games-misc/bsd-games-2.17-r3. From the name of patch in the tree, I guess this was accepted by older gcc versions.

Comment 5 Mr. Bones. (RETIRED) gentoo-dev

2009-04-27 15:57:20 UTC


*** This bug has been marked as a duplicate of bug 229759 ***

Comment 6 Ewan Marshall 2009-04-29 12:39:17 UTC

(In reply to comment #4)
> This is already fixed in =games-misc/bsd-games-2.17-r3. From the name of patch
> in the tree, I guess this was accepted by older gcc versions.
> 

Yeah, I submitted patch back in June.