| Summary: | Please keyword mail-client/alpine (and net-mail/topal) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Torsten Veller (RETIRED) <tove> |
| Component: | New packages | Assignee: | Net-Mail Packages <net-mail+disabled> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | enhancement | CC: | ada+disabled, gentoo, grimm26, herber, mgorny, pacho, proxy-maint, sascha_lucas, x86-fbsd+disabled |
| Priority: | High | Keywords: | KEYWORDREQ |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Torsten Veller (RETIRED)
2009-04-24 08:11:52 UTC
As I just commented in bug #266306, topal (and most other generic Ada packages) should depend on virtual/ada - either unversioned if it is version agnostic, or on either of ada-1995 or ada-2005, if it depends on a particular Ada standard. Not on virtual/gnat or either of dev-lang/gnat-gxx directly. I just submitted a stabilization request for virtual/ada (its dependencies - appropriate gnat-gxx versions, are already stabilized). If you want to move it along I guess you can comment there or make this bug depend on the stabilization one (bug #267442). (In reply to comment #1) > As I just commented in bug #266306, topal (and most other generic Ada packages) > should depend on virtual/ada - either unversioned if it is version agnostic, or > on either of ada-1995 or ada-2005, if it depends on a particular Ada standard. > Not on virtual/gnat or either of dev-lang/gnat-gxx directly. Fixed. Thanks. Keyworded on alpha (masked the topal use flag since gnat/ada is too big to support right now). ~amd64 added. ~ia64/~sparc done ppc keyworded alpine's code try to use "make" instead of "gmake". This cause build failure on BSD.
- configure.ac: AC_PATH_PROG(MAKE, make)
We can override this by assigning full "gmake" path to MAKE
- imap/Makefile and imap/c-client/Makefile hardcode "MAKE=make"
diff --git a/mail-client/alpine/alpine-2.00-r4.ebuild b/mail-client/alpine/alpine-2.00-r4.ebuild
index 755a234..fa3602d 100644
--- a/mail-client/alpine/alpine-2.00-r4.ebuild
+++ b/mail-client/alpine/alpine-2.00-r4.ebuild
@@ -66,6 +66,10 @@ src_prepare() {
use topal && epatch /usr/share/topal/patches/${P}.patch-{1,2}
epatch "${FILESDIR}"/2.00-lpam.patch
+
+ sed -i -e "/MAKE=/s/make/${MAKE:-make}/" \
+ imap/Makefile imap/src/osdep/unix/Makefile || die
+
cd "${S}/imap/src/c-client"
epatch "${FILESDIR}"/CVE-2008-5514.patch
}
@@ -74,7 +78,8 @@ src_configure() {
local myconf="--without-tcl
--with-system-pinerc=/etc/pine.conf
--with-system-fixed-pinerc=/etc/pine.conf.fixed
- --with-ssl-certs-dir=/etc/ssl/certs"
+ --with-ssl-certs-dir=/etc/ssl/certs
+ MAKE=$(type -P ${MAKE:-make})"
# fixme
# --with-system-mail-directory=DIR?
econf $(use_with ssl) \
(In reply to comment #7) > alpine's code try to use "make" instead of "gmake". This cause build failure > on BSD. =mail-client/alpine-2.00-r5 does not use the bundled c-client library but uses net-libs/c-client package. Can you please test again? Thank you. (In reply to comment #8) > (In reply to comment #7) > > alpine's code try to use "make" instead of "gmake". This cause build failure > > on BSD. > > =mail-client/alpine-2.00-r5 does not use the bundled c-client library but > uses net-libs/c-client package. Can you please test again? Thank you. Even with -r5, AC_PATH_PROG(MAKE, make) of configure.ac is still a problem. >>> Source configured. >>> Compiling source in /var/tmp/portage/mail-client/alpine-2.00-r5/work/alpine-2.00 ... gmake -j3 /usr/bin/make all-recursive make: illegal option -- - usage: make [-BPSXeiknpqrstv] [-C directory] [-D variable] [-d flags] [-E variable] [-f makefile] [-I directory] [-j max_jobs] [-m directory] [-V variable] [variable=value] [target ...] gmake: *** [all] Error 2 Looks like only x86-fbsd is left, and in the meantime packages became stale. |