Summary: | dev-java/sun-jdk-1.3.1.09.ebuild doesnt have fetch restriction | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tom Fredrik Blenning Klaussen <bfg-dev> |
Component: | New packages | Assignee: | Adrian Almenar <aalmenar> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.blenning.no/files/sun-jdk-1.4.1.04.ebuild | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 26932 |
Description
Tom Fredrik Blenning Klaussen
2003-08-15 10:43:39 UTC
Nice solution, for it, i have to review the new ebuild, and then, check some erros that are on the ebuild like fixed paths to /usr/portage/distfiles. Thanks, for filling the bug. Fixed for sun-jdk-{1.4.1.04|1.4.2}. This will be fixed for sun-jdk-1.3.1 soon. So i will not close this bug until its done for that version. Just felt like being a pain, so I made some further alterations :p I guess you noticed the fragility of the grep expression: startAt=`grep -aonm 1 ELF ${DISTDIR}/${At} | cut -d: -f1` in case you didn't it lays in the fact that we only match on the three letter word ELF. It's better to match on some binary nonsense, which makes up the ELF header. So what should be done is to replace the line above. With the lines below: #Match the 8 (Yes it's 8!) first letters in the ELF header: testExp=`echo -e "\0177\0105\0114\0106\0001\0001\0001"` startAt=`grep -aonm 1 ${testExp} ${DISTDIR}/${At} | cut -d: -f1` I Testes your last change and it worked perfect, also i changed sun-jdk-1.3.1 ebuild to have the fetch restriction, i will commit it tomorrow. Thanks. Commited to portage tree Going to my old bugs, marking this as verified :) Sorry closed is more correct |