| Summary: | [new package] mumbles-0.4-r1.ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jeremy Ebler <jebler> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | CONFIRMED --- | ||
| Severity: | enhancement | CC: | gentoo, kripton, leho |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.mumbles-project.org/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
The Ebuild
Improved ebuild Ebuild v3 |
||
|
Description
Jeremy Ebler
2009-04-17 12:29:15 UTC
Created attachment 188673 [details]
The Ebuild
This ebuild works for me, but is not quite yet production ready.
Major issue
* The scripts /usr/bin/mumbles and mumbles-send need to have a line changed:
-sys.path.append("/usr/share/python-support/mumbles/src/")
+sys.path.append("/usr/lib/python2.5/site-packages/src/")
I could do this with a patch, but it seems like there should be a more graceful way to make this change.
Minor issue
* The package's debain/control mentions a dependency of python-glade2, I'm not sure what gentoo package this translates to (`qsearch glade` didn't bring obvious results). -- (It worked fine for me, and it will probably work for most, but maybe not everyone.)
Created attachment 188675 [details] Improved ebuild This version of the ebuild takes care of the major issue I listed in comment #1 by using the following src_unpack. It works smoother than a patch-- I'm satisfied with this fix. src_unpack() { unpack ${A} cd "${S}" sed -i -e 's@"/usr/share/python-support/mumbles/src/"@"/usr/lib/python2.5/site-packages/src/"@' bin/mumbles bin/mumbles-send || die "sed failed" } DESCRIPTION seems much too long to me (max 100 chars). Created attachment 188846 [details]
Ebuild v3
Sorry, I didn't realize there were guidelines for DESCRIPTION length-- I just copied what I found in the DEBAIN/control file.
How about:
DESCRIPTION="A modern notification system, similar to libnotify or Growl on OSX"
I also realized that mumbles-0.4-r1 was incorrect, because the -rN is reserved for ebuild revisions.
I'm a little confused as to what the best way to version the ebuild is. It is release "0.4" but the source/deb downloads are titled "0.4-1" yet, the source unpacks to "0.4"
mumbles-0.4.1 is the correct gentoo-way to name this package, right?
If it is, then this ebuild handles the versions correctly.
(In reply to comment #4) > I also realized that mumbles-0.4-r1 was incorrect, because the -rN is reserved > for ebuild revisions. > > I'm a little confused as to what the best way to version the ebuild is. It is > release "0.4" but the source/deb downloads are titled "0.4-1" yet, the source > unpacks to "0.4" > > mumbles-0.4.1 is the correct gentoo-way to name this package, right? Actually, the debian '-1' refers to the packaging revision, not the application version, but this is distribution specific. If this were the second revision of the ebuild for Gentoo, then '-r1' would be correct, however since this is the first release of the 0.4 ebuild, and we don't worry about the debian package revision, it would just be 'mumbles-0.4.ebuild'. (In reply to comment #2) > sed -i -e > 's@"/usr/share/python-support/mumbles/src/"@"/usr/lib/python2.5/site-packages/src/"@' > bin/mumbles bin/mumbles-send || die "sed failed" > } > You cannot simply assume python version 2.5, so this is not the correct fix.(In reply to comment #5) > (In reply to comment #4) > > I also realized that mumbles-0.4-r1 was incorrect, because the -rN is reserved > > for ebuild revisions. > > > > I'm a little confused as to what the best way to version the ebuild is. It is > > release "0.4" but the source/deb downloads are titled "0.4-1" yet, the source > > unpacks to "0.4" > > > > mumbles-0.4.1 is the correct gentoo-way to name this package, right? > > Actually, the debian '-1' refers to the packaging revision, not the application > version, but this is distribution specific. If this were the second revision > of the ebuild for Gentoo, then '-r1' would be correct, however since this is > the first release of the 0.4 ebuild, and we don't worry about the debian > package revision, it would just be 'mumbles-0.4.ebuild'. > Oh, sorry - I see the source package is labelled '-1' too... I assume this is an error on the developer's part, since 0.3 was not labelled thus. In this case, either 0.4 or 0.4.1 is probably fine... but now I'm confused too :) is this project still alive? i'm looking for something to display growl notifications on linux. even some gateway solution to notify-send would be just fine. sorry for OT, for anyone else looking, https://github.com/mattn/growl-for-linux looks alive and interesting. Is this still needed? $URL is down |
