Summary: | [patch] sys-kernel/genkernel-9999 (commit 109770b7) doesn't pass CROSS_COMPILE through to busybox, etc so strip and similar get called for the wrong arch | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Mike Auty (RETIRED) <ikelos> |
Component: | genkernel | Assignee: | Gentoo Genkernel Maintainers <genkernel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sping |
Priority: | High | Keywords: | Inclusion |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | genkernel-9999-cross-strip.patch |
Description
Mike Auty (RETIRED)
2009-04-05 19:20:24 UTC
Created attachment 187398 [details, diff]
genkernel-9999-cross-strip.patch
What is the point of setting CROSS_COMPILE=$UTILS_CROSS_COMPILE in the patch? That var isn't used anywhere. It gets exported to ARGS in compile_generic() (or at least, that was the intention), such that during the eval command, busybox's make and so forth will get handed CROSS_COMPILE, and correctly append it to the strip command in their Makefiles (busybox does an internal strip, then genkernel does a strip afterwards). The original error I was hitting was in busybox's strip (not genkernel's), because whilst it was supposed to use "${CROSS_COMPILE}strip", that ended up just calling strip... In fact, I probably wanted to add them to compile_utils_args(), but instead only added them to export_utils_args(). Since both seem to happen, the output only print CC, LD and AS, but I think make will be handed CROSS_COMPILE through the env and still make use of it. Would you like me to fix up the patch so that compile_utils_args() gets the same treatment? I was mostly duplicating the kernel's side of things, but it seems I missed that one... PS: Adding keyword "Inclusion" and "[patch] " prefix to better show this bug's nature in searches... InGit. |