Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 264090

Summary: Kernel-2.6.29 needs a patch to make forcedeth work without hangs.
Product: Gentoo Linux Reporter: Víctor Enríquez <victor.quicksilver>
Component: [OLD] Core systemAssignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel>
Severity: normal CC: gengor, Manfred.Knick, mark+gentoobugs, subs, thomas.jaeger, tmokros
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Attachments: Second patch from the thread specefied in the url bug.

Description Víctor Enríquez 2009-03-28 17:49:43 UTC
Forcedeth needs some patching to work ok in 2.6.29, else it hangs after a while. (With and without NAPI) 

Reproducible: Always
Comment 1 Víctor Enríquez 2009-03-28 17:52:11 UTC
Created attachment 186575 [details, diff]
Second patch from the thread specefied in the url bug.

Tested here, seems to solve the problem (More than 2 hours running with heavy network load without a problem)
Comment 2 Mike Pagano gentoo-dev 2009-03-28 22:12:17 UTC
I wonder if it's this one that we actually want?;a=commitdiff;h=8f1ead2d1a626ed0c85b3d2c2046a49081d5933f

We get our patches off of the repositories rather than the mailing lists as they tend to change before they get committed.
Comment 3 Víctor Enríquez 2009-03-29 02:03:59 UTC
first, thanks for your support :).
I don't know what patch should work better, I can test the other patch if you want. 
By the way the included patch is working fine (No hangs since I post this).
Anyway the fix should be included in so maybe we can let this bug open, until the next stable version is out, and close then. 
Comment 4 Mike Pagano gentoo-dev 2009-03-29 16:14:28 UTC
If no one is a rush and we think will be out before we do another genpatches (probable), we can wait on the next patchset.
Comment 5 Andrew Evans 2009-04-04 21:30:43 UTC
I got bitten by this too. I had to reboot my mail server several times due to this bug. At first I thought it was my router's fault.

It's definitely a short-term patch, but I vote for cutting a new release of 2.6.29 with it added. 2.6.29 as it stands is not going to work for people with forcedeth NICs unless they set the experimental NAPI option in their kernel config.
Comment 6 Andrew Evans 2009-04-04 21:31:49 UTC
BTW I'm running Herbert Xu's patch from comment #2 and it fixes the problem for me.
Comment 7 Andrew Evans 2009-04-04 21:37:35 UTC
Err, never mind, was released on 2 Apr 2009 and it contains Herbert's patch. Can we get an ebuild for this ASAP please?
Comment 8 Mike Pagano gentoo-dev 2009-04-05 01:46:21 UTC
gentoo-sources-2.6.29-r1 released which contains the patch set.
Comment 9 Manfred Knick 2009-08-12 09:25:08 UTC
(In reply to comment #8)
> gentoo-sources-2.6.29-r1 released which contains the patch set.
Hi, Mike,
I'm running an ASUS M2N-SLI Deluxe with nForce 570 SLI, providing dual MCP MAC with Marvell PHY - thus enabled "CONFIG_FORCEDETH" in the kernel.

Rebooting *from* 2.6.27, both get recognized fine.
Rebooting *from* 2.6.29-r5 as well as 2.6.29-r6, I suffer from having to completely power-off the box.

To me this seems to indicate that during shutdown of the network, the interfaces become configured into a mode where the bios dows not re-recognize them again.

Thus, I propose to re-open this bug.
Comment 10 Manfred Knick 2009-08-12 09:52:21 UTC
(In reply to comment #9)
> (In reply to comment #8)

Re-thinking, I suspect the PHY part even more than the MAC.

And I found

pointing to;a=commit;h=5a9a8e32ebe269c71d8d3e78f9435fe7729f38e9


forcedeth: add phy_power_down parameter, leave phy powered up by default (v2)

Add a phy_power_down parameter to forcedeth: set to 1 to power down the
phy and disable the link when an interface goes down; set to 0 to always
leave the phy powered up.

The phy power state persists across reboots; Windows, some BIOSes, and
older versions of Linux don't bother to power up the phy again, forcing
users to remove all power to get the interface working (see  Leaving the phy
powered on is the safest default behavior.  Users accustomed to seeing
the link state reflect the interface state and/or wanting to minimize
power consumption can set phy_power_down=1 if compatibility with other
OSes is not an issue.


This issue is being handled in
Comment 11 Manfred Knick 2009-08-12 13:46:34 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)

I can confirm that this issue has been solved at least in
as well as in
 vmlinuz-2.6.30-gentoo-r4 , basing upon  vanilla sources 2.6.30 patch 4