Bug 263979 – [PATCH] net-libs/xulrunner C++ exceptions check fails

• Product: Gentoo Linux
• Status: RESOLVED UPSTREAM

[Description Hanno Zysik (geki) 2009-03-27 16:33:14 UTC]

Mozilla configure does some funny exceptions check and fails.
It therefore adds -fno-handle-exceptions flag instead of -fno-exceptions.

Patch attached.

[Comment 1 Hanno Zysik (geki) 2009-03-27 16:34:00 UTC]

Created attachment 186444 [details]
build.log with wrong result for C++ exceptions check

[Comment 2 Hanno Zysik (geki) 2009-03-27 16:34:52 UTC]

Created attachment 186446 [details, diff]
clean and fix C++ exceptions check

[Comment 3 Hanno Zysik (geki) 2009-03-27 17:11:41 UTC]

Hmm, run configure manually selects -fno-exceptions, run via emerge it selects -fno-handle-exceptions.
Let's see.

[Comment 4 Hanno Zysik (geki) 2009-03-27 17:36:12 UTC]

Created attachment 186455 [details, diff]
remove exceptions check and enforce -fno-exceptions

... since noone uses g++ <2.8 nowadays?

[Comment 5 Jory A. Pratt 2009-05-31 13:39:52 UTC]

(In reply to comment #4)
> Created an attachment (id=186455) [edit]
> remove exceptions check and enforce -fno-exceptions
> 
> ... since noone uses g++ <2.8 nowadays?
> 

actually the check is fine as mozilla tries to maintain backward compatibility as long as possible.

[Comment 6 Hanno Zysik (geki) 2009-05-31 23:41:30 UTC]

The idea of the check is fine, yes.
The implementation of the check adds the wrong flag. ;)
See comment 0.

Looking at http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-devel/gcc/
there is the version 2.95 the oldest. Now with that, the check is simply superfluous.
Please tell me about a box that uses <gcc-2.8 to build xulrunner. :)

I wonder if that versions are even able to build it. ;)

[Comment 7 Jory A. Pratt 2009-07-20 03:13:22 UTC]

Please open a bug upstream. If they decide they want to fix it we will fix it in gentoo. There is nothing that is gonna be broken by the exception check.