| Summary: | Fix libX11 cross-compilation | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sven 'sleipnir' Rebhan <OdinsHorse> |
| Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED NEEDINFO | ||
| Severity: | normal | CC: | embedded, j-pi |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://bugs.freedesktop.org/show_bug.cgi?id=20981 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Ebuild part of the patch
Cross-compile fix Corrected ebuild patch Autoreconf fix for configure.ac Reworked patch |
||
|
Description
Sven 'sleipnir' Rebhan
2009-03-27 07:15:04 UTC
Created attachment 186382 [details, diff]
Ebuild part of the patch
Apply the patch in the ebuild. (Align the use switches)
Created attachment 186384 [details, diff]
Cross-compile fix
Compile a host version of the required makekeys tool when we cross-compile. A smilar patch for libXt can be found in #263897.
Created attachment 186387 [details, diff]
Corrected ebuild patch
Wooops, we also need to remove the previous cross-compile hack and do an autoreconf. This fails without the patch that follows.
Created attachment 186389 [details, diff] Autoreconf fix for configure.ac Without the patch I get the following error during autoreconf: > error: possibly undefined macro: XTRANS_CONNECTION_FLAGS > If this token and others are legitimate, please use m4_pattern_allow. > See the Autoconf documentation. In configure.ac the XTRANS_CONNECTION_FLAGS macro is forbidden rather than allowed. That seems to be wierd. Allowing this macro fixes autoreconf. Please open a bug in FreeDesktop's bugzilla with your patch attached to it and paste the url here. Thanks the comments in Bug 263897 apply to this patch as well Created attachment 186884 [details, diff]
Reworked patch
Make use of the cross_compile variable and respect preset CC_FOR_BUILD. Hope this makes vapier happy!? Will submit upstream and paste the URL here.
Submitted upstream as http://bugs.freedesktop.org/show_bug.cgi?id=20981 Upstream seems to think the bug is already fixed... That's true for version 1.1.99 or 1.2. So we either bump the version here or backport the Xorg fix or apply the patch as is. Upstream also thinks that the xtrans macro patch is wrong, however I can't reconfgure the package without it. Maybe it's a problem with my environment, because I think I have x11-libs/xtrans installed (this should provide the missing macro). Comment on attachment 186389 [details, diff]
Autoreconf fix for configure.ac
The problem was an artefact of cross-compilation (host was missing xtrans). The patch is not required.
So the only problem left is the makekeys issue. How to proceed? Version bump? Backporting? Taking the current tested patch? (In reply to comment #9) > Upstream seems to think the bug is already fixed... I think this might just be a "better" fix. Anybody poked at what is upstream now? Upstream says bug is fixed. Could anyone enlighten me on what needs to be done here? Aren't newer versions (that I yet have to unmask...) fixed? Thanks Cross compiling the libX11-1.2.2 ebuild works for arm and powerpc but still has a CFLAG vs. CFLAG_FOR_BUILD issue that causes cross compiling mips64 to fail as -mabi is part of CFLAGS. There is a corresponding bug and a proposed patch at https://bugs.freedesktop.org/show_bug.cgi?id=22584. Creating a new patch for 1.1.5 based on this should be possible, right? Then please send the patch to the xorg-devel mailing list, so that it gets reviewed/applied soon. Once the patch is in git, I'll backport it or even roll out a new release. Thanks |
