Summary: | x11-libs/libXt: Better patch for cross-compiling | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sven 'sleipnir' Rebhan <OdinsHorse> |
Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED NEEDINFO | ||
Severity: | minor | CC: | embedded |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Better patch for libXt
Better patch for libXt - ebuild part Automake/conf fixes Reworked patch enables xcompilation of libXt-1.0.6 set CFLAGS_FOR_BUILD in ebuild |
Description
Sven 'sleipnir' Rebhan
2009-03-26 20:18:49 UTC
Created attachment 186355 [details, diff]
Better patch for libXt
This patch applies to the libXt ebuild. It does not require the makestr binary to be available on the compile host, but rather compiles a host version itself.
Pretty sure x11 team would prefer all patches be done to the source vs the ebuilds. I just "copied" the solution to libX11's makekeys. However, if they want me to do a better patch to the sources, they will tell me hopefully!? We allways prefer patch to sources that can be pushed upstream. It is quite logical :] Created attachment 186364 [details, diff]
Better patch for libXt - ebuild part
You want love, you get love...
Created attachment 186366 [details, diff]
Automake/conf fixes
Your whish is my command!
A patch for libX11 will follow in a separate patch. (In reply to comment #5) > Created an attachment (id=186364) [edit] > Better patch for libXt - ebuild part Good work Sven. At this rate you keep it up and one of us poor suckers is going to have to mentor you. (In reply to comment #7) > A patch for libX11 will follow in a separate patch. Ok but can you do that in another bug please? This one here you reserved for libXt. A simlar patch for libX11 can be found in #263937. Please open a bug in FreeDesktop's bugzilla with your patch attached to it and paste the url here. Thanks well, you know about $cross_compiling, but you dont always use it, so that's odd unless there's an X standard for using XX_FOR_BUILD, i'd suggest we go with BUILD_XX style you should use +set style to figure out whether a var is set: if test "x${BUILD_CC+set}" != "xset" ; then if test "x$cross_compiling" = "xyes" ; then BUILD_CC=gcc else BUILD_CC=$CC fi fi does incrementing noinst_PROGRAMS not work ? if CROSS_COMPILING noinst_PROGRAMS += xmakestrs$(EXEEXT) Created attachment 186804 [details, diff]
Reworked patch
Some fixes of vapier applied. However, I sticked with CC_FOR_BUILD as the config.guess in the project dir also had this as a name for the host compiler.
I will submit the patch to Freedesktop's bugzilla in the next days and paste the link here... Upstream submission: http://bugs.freedesktop.org/show_bug.cgi?id=20958 Upstream says this is already fixed. Care to let me know what needs to be done now? Thanks (In reply to comment #15) > Upstream says this is already fixed. Care to let me know what needs to be done > now? it is fixed in a way which doesn't work for gentoo/xcompile I addapted sleipnir's patch for libXt-1.0.6 and modified the ebuild. now it cross-compiles... Created attachment 203895 [details, diff]
enables xcompilation of libXt-1.0.6
Created attachment 203896 [details, diff]
set CFLAGS_FOR_BUILD in ebuild
Again, please file a bug upstream and paste the url here so that this patch gets a proper review. I won't add patches that are not accepted or ACKed by upstream. Thanks |