| Summary: | x11-base/xorg-server USE="hal nptl sdl tslib xorg" cross compilation fails | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Maksim 'max_posedon' Melnikau <maxposedon> |
| Component: | New packages | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arm, armin76, embedded |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | ARM | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
xorg-server-1.5.3-r5 build log
fix cross pthread xorg-server ebuild patch |
||
|
Description
Maksim 'max_posedon' Melnikau
2009-03-25 01:37:07 UTC
Created attachment 186161 [details]
xorg-server-1.5.3-r5 build log
gzipped because of too big files size
http://gentoo.mindzoo.de/index.cgi/browser/openmoko/trunk/openmoko-target/x11-base/xorg-server/files/1.5.3-fix-cross-pthread.patch This is not very correct patch (-lpthread shoudn't be added always, just when USE="nptl"). Created attachment 186219 [details, diff]
fix cross pthread
correct patch
Created attachment 186222 [details, diff]
xorg-server ebuild patch
I found that this problem fixed in upstream already by few commits, one of them is here: http://cgit.freedesktop.org/xorg/xserver/commit/?id=ae38151ddda9984effca5bb7c582540061201dce (I'll try find all) One more commit to xorg-server that fixes this bug. http://cgit.freedesktop.org/xorg/xserver/commit/?id=efb723e166e5fa89e90c7b400fb4c7979b1f50c0 So, we have a kind of problem now: 1. bug fixed in upstream xorg 2. cherry-picking xorg patches doesn't woks "out of the box" 3. my patch works So, can I hope that it will goes upstream? (for <1.5.99.1) (In reply to comment #7) > So, can I hope that it will goes upstream? (for <1.5.99.1) I mean gentoo portage here. I'll backport it to 1.5.3 once upstream commits it to the main git repo. Thanks i think upstream has committed everything ? it's just a matter of finding them I'm waiting for this to get fixed for stabilizing xorg-server-1.5 on arm I'm a bit confused about this bug here. Could you tell me which upstream patch you want backported? If it's the one that's attached, please send it upstream (xorg-devel mailing list or through bugzilla) so that upstream can take a closer look at it. Thanks (In reply to comment #12) > I'm a bit confused about this bug here. Could you tell me which upstream patch > you want backported? > > If it's the one that's attached, please send it upstream (xorg-devel mailing > list or through bugzilla) so that upstream can take a closer look at it. > > Thanks > My comment 5 and comment 6: http://cgit.freedesktop.org/xorg/xserver/commit/?id=ae38151ddda9984effca5bb7c582540061201dce http://cgit.freedesktop.org/xorg/xserver/commit/?id=efb723e166e5fa89e90c7b400fb4c7979b1f50c0 My patch is kind of small version of this commits. Alright, thanks, I'll try to look into it a bit more. (In reply to comment #13) > http://cgit.freedesktop.org/xorg/xserver/commit/?id=ae38151ddda9984effca5bb7c582540061201dce > http://cgit.freedesktop.org/xorg/xserver/commit/?id=efb723e166e5fa89e90c7b400fb4c7979b1f50c0 Donnie, you actually applied this patch to upstream's 1.5 branch but you left out the part that changes KDRIVE_LIBS. Was that intentional? Thanks (In reply to comment #14) > Alright, thanks, I'll try to look into it a bit more. > > (In reply to comment #13) > > > Donnie, you actually applied this patch to upstream's 1.5 branch but you left > out the part that changes KDRIVE_LIBS. Was that intentional? > > Thanks > Frankly speaking I wrote my patch before I found that patches in upstream, but I can't apply this patches to 1.5.3. And sorry, don't get your question, my patch fixes KDRIVE_LIBS too.... Remi, please catch me on IRC, I'm having a hard time following this bug to figure out what's going on. 1.5.3-r6 has (among its 78 patches) the 2 patches linked in comment #13. Please test this revbump as much as possible, because if it works for you, I'll push its stabilization a little sooner than the usual 30 days. Thanks |
