Summary: | [EBUILD] dev-java/velocity-dvsl-1.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ralph Sennhauser (RETIRED) <sera> |
Component: | [OLD] Java | Assignee: | Java team <java> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://velocity.apache.org/dvsl/devel/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
The ebuild
updated ebuild |
Description
Ralph Sennhauser (RETIRED)
![]() Created attachment 185969 [details]
The ebuild
(In reply to comment #1) > Created an attachment (id=185969) [edit] > The ebuild > New Java ebuilds should use EAPI 2 as it makes the eclasses behave a little better. > IUSE="test" Put this to JAVA_PKG_IUSE too. > EANT_BUILD_TARGET="jar" This is the default. > if (use test); then This creates a useless sub shell, you should do these java-pkg_jar-from calls in src_test instead. Also as a general reminder make sure you have JAVA_PKG_STRICT=1 in make.conf while creating Java ebuilds. (In reply to comment #2) > (In reply to comment #1) > > IUSE="test" > > Put this to JAVA_PKG_IUSE too. Is this true for all use flags or is test considered a "java useflag"? Right now at least it doesn't rewrite the default src_test function. > > if (use test); then > > This creates a useless sub shell, you should do these java-pkg_jar-from calls > in src_test instead. As this is a onetime call I thought this wouldn't matter and result in a bit better readability. > Also as a general reminder make sure you have JAVA_PKG_STRICT=1 in make.conf > while creating Java ebuilds. > I have also dev-java/java-dep-check installed. Are there more than those two witch I'm not aware of? Will attach an ebuild with the proposed changes and move the test dependencies from COMMON_DEP to DEPEND. Thanks for your comments. Created attachment 186406 [details]
updated ebuild
commit a861972 Author: Patrice Clement <monsieurp@gentoo.org> Date: Sun Feb 21 16:20:56 2016 +0000 dev-java/velocity-dvsl: Introduce velocity-dvsl. Fixes bug 263457. Package-Manager: portage-2.2.26 create mode 100644 dev-java/velocity-dvsl/Manifest create mode 100644 dev-java/velocity-dvsl/metadata.xml create mode 100644 dev-java/velocity-dvsl/velocity-dvsl-1.0.ebuild |