Bug 263416

Summary:	media-sound/squeezecenter-7.3.2-r1 RDEPENDS on too new a version of dev-perl/JSON-XS
Product:	Gentoo Linux	Reporter:	Tim Dodge <timmy>
Component:	New packages	Assignee:	Joe Peterson (RETIRED) <lavajoe>
Status:	VERIFIED FIXED
Severity:	normal	CC:	stuart
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Updated JSON::XS patch

Description Tim Dodge 2009-03-22 20:58:57 UTC

Lots of bits of squeezecenter aren't working for me, I've tracked down most of the problems to error messages like this:

Slim::Plugin::LastFM::ProtocolHandler::_gotNextTrack (148) Last.fm error getting next track: JSON::XS::from_json has been renamed to decode_json, either downgrade to pre-2.0 versions of JSON::XS or rename the call at /usr/lib64/perl5/vendor_perl/5.8.8/Slim/Plugin/LastFM/ProtocolHandler.pm line 144

grepping through the files installed by the squeezecenter revels quite a few calls to from_json.

Reproducible: Always

Comment 1 Tim Dodge 2009-03-22 21:25:26 UTC

I've just tried downgrading to JSON-XS-1.52 and squeezecenter won't even start.

It looks like the calls to from_json are mostly in plugins that I guess the main squeezecenter devs don't touch.

Perhaps we need some sed & awk in the ebuild to rename from_json and to_json to decode_json and encode_json?

Comment 2 Stuart Hickinbottom 2009-03-23 20:49:47 UTC

You're right - there is a problem here. However I think it's just in the following files:

/usr/lib/perl5/vendor_perl/5.8.8/Slim/Plugin/Sirius/ProtocolHandler.pm
/usr/lib/perl5/vendor_perl/5.8.8/Slim/Plugin/LastFM/ProtocolHandler.pm

The other files that you find from_json in use JSON::XS::VersionOneAndTwo which automatically converts from_json/to_json to the newer forms if you're using a newer version of JSON::XS.

I'll update the ebuild to also fix those two plugins to also use VersionOneAndTwo. I'll post back here when I've done that.

Comment 3 Stuart Hickinbottom 2009-03-23 21:47:45 UTC

Created attachment 186048 [details, diff]
Updated JSON::XS patch

Joe, attached is an updated JSON::XS patch for the 7.3.2-r1 ebuild; I've tested this with 7.3.2-r1 and successfully submitted tracks to LastFM, so I believe it's working and resolves this bug.

Comment 4 Stuart Hickinbottom 2009-03-25 08:01:49 UTC

I've also submitted this patch upstream to hopefully remove the need for the ebuild to maintain this local modification (http://bugs.slimdevices.com/show_bug.cgi?id=11463).

Comment 5 Joe Peterson (RETIRED) gentoo-dev

2009-03-25 17:11:40 UTC

Stuart, thanks!

I've committed this as 7.3.2-r2.  Note also that I have used the full rev now in the epatch for this patch.  This is so -r1 will not pick up the fix.  We'll want to adjust this back with future versions.

Comment 6 Stuart Hickinbottom 2009-06-10 07:03:28 UTC

This has now been fixed upstream (http://svn.slimdevices.com/slim?rev=26976&view=rev). Can this be closed - the original report seems to have gone quiet?

Comment 7 Tim Dodge 2009-06-10 08:10:28 UTC

Fine by me, the patch fixed the problems I was experiencing.

Thanks.

Comment 8 Stuart Hickinbottom 2009-06-10 08:24:23 UTC

Thanks for confirming that. I'm not the assignee of the bug so can't close it, but I think either you or Joe could do that.