| Summary: | media-sound/rhythmbox-0.10.1-r1 fails to emerge | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andrey Vihrov <andrey.vihrov> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | amigadave, asl, gstreamer, sound |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Build log | ||
|
Description
Andrey Vihrov
2009-03-11 18:56:11 UTC
Created attachment 184725 [details]
Build log
I'm also getting this on amd64 stable after the Gnome 2.24 update. The relevant error appears to be: ../lib/rb-proxy-config.h:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token which appears to be triggered by these lines (68-70) in rb-proxy-config.h: #if defined(HAVE_LIBSOUP) SoupUri * rb_proxy_config_get_libsoup_uri (RBProxyConfig *config); #endif Looking at http://library.gnome.org/devel/libsoup/stable/libsoup-porting-2.2-2.4.html it seems that "SoupUri" has been changed to "SoupURI" in libsoup 2.24. There are some other changes mentioned which may affect behaviour, and I'm not at my Gentoo machine to check if making the change will fix the problem. There is a dependency for >=net-libs/libsoup-2.2.99:2.2 in the Rhythmbox ebuild, but the configure.ac has this check: dnl Check for libsoup, needed for DAAP and audioscrobbler if test "x$enable_daap" = "xyes" || test "x$enable_audioscrobbler" != "xno"; then PKG_CHECK_MODULES(SOUP, \ libsoup-2.2, have_libsoup=yes, have_libsoup=no) if test x"$have_libsoup" = "xno"; then PKG_CHECK_MODULES(SOUP, libsoup-2.4, have_libsoup=yes, have_libsoup=no) fi if test x"$have_libsoup" = "xyes"; then AC_DEFINE(HAVE_LIBSOUP, 1, [Define if libsoup support is enabled]) fi fi which appears to distinguish between the 2.2 (pre-2.24) and 2.4 (2.24) APIs. However, the line in rb-proxy-config.h is not altered, so the build breaks if using the 2.4 API. I can try to make a patch to fix Rhthmbox this evening, but this may be a good time to make a newer version of Rhythmbox stable? (In reply to comment #2) > this may be a good time to make a newer version of Rhythmbox stable? You are correct, see bug #234306. (In reply to comment #3) > (In reply to comment #2) > > this may be a good time to make a newer version of Rhythmbox stable? > > You are correct, see bug #234306. Andrey, I think that you are right. The patch on the GNOME bugzilla for cleaning up libsoup support in Rhythmbox is http://bugzilla.gnome.org/show_bug.cgi?id=509701 but as this is included in newer versions anyway, it seems best to stable them instead than patch old versions. Yes rhythmbox needs a more recent stable version. *** This bug has been marked as a duplicate of bug 234306 *** |