| Summary: | net-misc/hamachi installs prebuilt binary in /usr | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Component: | New packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | rk.katana.steel, treecleaner |
| Priority: | High | Keywords: | PMASKED |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | Pending removal: 2010-08-12 | ||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
new-ish ebuild for the package
change log for the ebuild patch to bulld the tuncfg diff from the tree version |
||
|
Description
Diego Elio Pettenò (RETIRED)
2009-03-08 19:13:47 UTC
The package is also: - Calling `use` in global scope(!) - Using make instead of emake - Falsely RESTRICTing "strip" where as it should use QA_PRESTRIPPED - Missing || die's for all install commands - Installs LICENSE files in dodoc - and, sigh, is missing same LICENSEs from LICENSE="" field I don't care enough to rewrite the ebuild, so adding treecleaner@ The above was just my 30 seconds of observation, there's likely more (note that we are already removing the client, ghamachi, in another bug, which is why I noticed this bug) # Jeremy Olexa <darkside@gentoo.org> (12 Jun 2010) # Many, many ebuild issues. No maintainer # Removed in 60 days by treecleaners, bug 261745 net-misc/hamachi I wouldn't mind cleaning up the ebuild on this, seeing as I use this. You don't need our permission. Go for it :) Created attachment 235951 [details]
new-ish ebuild for the package
the new ebuild that installed net-misc/hamachi in /opt/hamachi
Created attachment 235953 [details]
change log for the ebuild
Created attachment 235955 [details]
patch to bulld the tuncfg
patch to bulld the tuncfg from the supplied source code
I'm wondering, are the proposed ebuild okay? could I get some feedback as why not if it isn't e.g. what's missing still. the -r bump is done because of distination change of the installed files. Could you please attach a diff between your ebuild and the one located on tree? It will be easier for us to review it Created attachment 238125 [details]
diff from the tree version
a 'diff -u <tree> <modified>' diff of the ebuild, as requested by Markos :)
Sorry for not doing so at the time of submitting, and thanks for telling.
The changelog is straight forward, I've only added to the top of it
I looked at the diff quickly and it looks like it can pass the QA control. Jeremy can we remove the masking of this package and push the new revision on tree? (In reply to comment #12) > I looked at the diff quickly and it looks like it can pass the QA control. > Jeremy can we remove the masking of this package and push the new revision on > tree? > Yup, you don't need to ask. It is kinda the treecleaners "job" to save packages if/when users are interested. +*hamachi-0.9.9.9_p20-r5 (11 Jul 2010) + + 11 Jul 2010; Markos Chandras <hwoarang@gentoo.org> + -hamachi-0.9.9.9_p20-r4.ebuild, +hamachi-0.9.9.9_p20-r5.ebuild, + +files/tuncfg-forcebuild.patch: + Revbump. Fixes multiple issues. Bug #261745. Thanks to René Kjellerup + <rk.katana.steel@gmail.com> for the patches and all the ebuild QA fixes + Saved. Thanks Rene :) You're welcome Markos, and it was my pleasure. I would have hated to see this one go :) I don't use the GUI but this package is important to me. and thanks to you for pushing it into the tree. |
