Bug 261664

Summary:	app-emulation/kqemu-1.4.0_pre1 fails to build
Product:	Gentoo Linux	Reporter:	Peter Volkov (RETIRED) <pva>
Component:	Current packages	Assignee:	Luca Barbato <lu_zero>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	243582, 260876
Attachments:	kqemu-1.4.0_pre1-missing-sched-header.patch kqemu-1.4.0_pre1.ebuild.patch

Description Peter Volkov (RETIRED) gentoo-dev

2009-03-08 10:47:19 UTC

app-emulation/kqemu-1.4.0_pre1 fails to build with the following error:

make[1]: Leaving directory `/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/common'
make -C /usr/src/linux M=`pwd` modules
make[1]: Entering directory `/usr/src/linux-2.6.28-gentoo-r2'
  CC [M]  /vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.o
/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.c: В функции ‘kqemu_lock_user_page’:
/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.c:81: ошибка: доступ по указателю на неполный тип
/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.c: В функции ‘kqemu_schedule’:
/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.c:194: ошибка: неявная декларация функции ‘need_resched’
/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.c:195: ошибка: неявная декларация функции ‘schedule’
/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.c:197: ошибка: неявная декларация функции ‘signal_pending’
make[2]: *** [/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1/kqemu-linux.o] Ошибка 1
make[1]: *** [_module_/vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/work/kqemu-1.4.0pre1] Ошибка 2
make[1]: Leaving directory `/usr/src/linux-2.6.28-gentoo-r2'
make: *** [kqemu.ko] Ошибка 2
>>> Source compiled.
>>> Test phase [not enabled]: app-emulation/kqemu-1.4.0_pre1

>>> Install kqemu-1.4.0_pre1 into /vt/portage/tmp/portage/app-emulation/kqemu-1.4.0_pre1/image/ category app-emulation
 * Installing kqemu module
install: невозможно выполнить stat для `kqemu.ko': Нет такого файла или каталога
!!! doins: kqemu.ko does not exist


This bug was already reported in number of places and fix found:
http://archive.netbsd.se/?ml=qemu-devel&a=2008-05&t=7519765
http://article.gmane.org/gmane.comp.emulators.qemu/18976

Patch follows.

Comment 1 Peter Volkov (RETIRED) gentoo-dev

2009-03-08 10:48:43 UTC

Created attachment 184323 [details, diff]
kqemu-1.4.0_pre1-missing-sched-header.patch

Comment 2 Peter Volkov (RETIRED) gentoo-dev

2009-03-08 11:36:46 UTC

Created attachment 184324 [details, diff]
kqemu-1.4.0_pre1.ebuild.patch

This is patch for ebuild which:
1. applies above patch.
2. Fixed not catching make build problem (see, build failed, but portage still runs src_install, this is because missing || die)
3. It fixes bug #260876 (clean -Werror)
4. It fixes bug #243582 (not respecting CC)
5. Also it makes build respect CFLAGS.

Probably last three items are fixed not in ideal way but it's hard to do better without knowing upstream intentions on what they want their build system to be... Currently Makefiles are mess thus fix is kind of mess too :)

Comment 3 Luca Barbato gentoo-dev

2009-03-08 16:32:23 UTC

Wonderful =) Commit anytime

Comment 4 Luca Barbato gentoo-dev

2009-03-09 09:45:46 UTC

I committed it myself with some minor changes, thank you again for the help