Bug 261372 – sys-apps/portage-2.2.00.10347 doesn't quote 'portagegroup' value in Makefile

• Product: Gentoo/Alt
• Status: RESOLVED NEEDINFO

[Description Jeremy Olexa (darkside) (RETIRED) 2009-03-05 22:01:11 UTC]

roh-uh!

While bootstrapping on interix, the Makefile contains this: 

portagegroup = Domain Users

install(1) does NOT work with spaces in group name. Confirmed that even r12671 does not properly quote either. I found that for every Makefile.in in the portage source, there is portagegroup = @portagegroup@ - I fixed this now via:

find . -name Makefile.in|xargs sed -i -e 's/@portagegroup@/"@portagegroup@"/'

in the bootstrap-prefix.sh script. I wonder if it is safe to go upstream to trunk? I tested this on amd64-linux - looks fine. There shouldn't be an issue with adding quotes here. Maybe more values need to be quoted as well?? 

CC-ing dev-portage for input too.

thx.

[Comment 1 Jeremy Olexa (darkside) (RETIRED) 2009-03-05 22:04:10 UTC]

Oh..

Somehow this change is too harse, I end up with errors like:

/bin/sh ../subst-install --installcmd='/prefix/tmp/usr/bin/install -c -o Jeremy_
Olexa -g Domain Users -m 755' ././xpak /prefix/usr/lib/portage/bin/./xpak
/prefix/tmp/usr/bin/install: target `/prefix/usr/lib/portage/bin/./xpak' is not
a directory
make[2]: *** [install] Error 1
make[2]: Leaving directory `/prefix/var/tmp/portage-2.2.00.10347/prefix-portage-
2.2.00.10347/bin'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/prefix/var/tmp/portage-2.2.00.10347/prefix-portage-
2.2.00.10347'
make: *** [install] Error 2

Bummer. Anyone else got an idea?

[Comment 2 Fabian Groffen 2009-03-12 20:14:50 UTC]

potential fix in r13100

[Comment 3 Fabian Groffen 2009-04-03 18:40:19 UTC]

please reopen if still not fixed.