| Summary: | net-mail/mlmmj-1.2.16 perl admin webinterface does not check returncodes | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Florian Streibelt <gentoo> |
| Component: | Current packages | Assignee: | Net-Mail Packages <net-mail+disabled> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | CC: | net-mail+disabled |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
in the very same file some lines below you will find some code that ALWAYS spits out your subscription failed, even when it worked out. " error adding foo@bar.de (code 0) " {this code was never tested, was it} ;=) 116 if ($email =~ /^[a-z0-9\.\-_\@]+$/i) { 117 if ($subscriber) { 118 system "$mlmmjsub -L $topdir/$list -a $email -U -s"; 119 } 120 if ($digester) { 121 system "$mlmmjsub -L $topdir/$list -a $email -Ud -s"; 122 } 123 if ($nomailsub) { 124 system "$mlmmjsub -L $topdir/$list -a $email -Un -s"; 125 } 126 $action = "error adding $email (code $?)"; 127 } else { 128 $action = '"'.encode_entities($email).'" is not a valid email address.'; please report upstream: http://mlmmj.org/project/issues/mlmmj Closing. Please inform if you do report upstream. |
again in subcribers.cgi. the webinterface does not check the returncode of the subscribe-command but instead tries to find out itself in advance if the mailadress is vaild. If the call fails due to some other reason (maybe because they use another regex to check the address there) we will still get a success message :( 97 if ($email =~ /^[a-z0-9\.\-_\@]+$/i) { 98 if ($subscriber) { 99 system "$mlmmjsub -L $topdir/$list -a $email -U -s"; 100 } 101 if ($digester) { 102 system "$mlmmjsub -L $topdir/$list -a $email -Ud -s"; 103 } 104 if ($nomailsub) { 105 system "$mlmmjsub -L $topdir/$list -a $email -Un -s"; 106 } 107 $action .= "$email has been subscribed.<br>\n"; 108 } else { 109 $action .= '"'.encode_entities($email).'" is not a valid email address.<br>'; 110 } Reproducible: Always Steps to Reproduce: