Summary: | media-video/mjpegtools: Request to make X11 optional by USE flag | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Vladimir Monchenko <bobmvg> |
Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | billie, chtof62, gentoo-bugs, gentoobugs, hyedad, media-tv, n-roeser, remy, stefan-r-bz, stefan |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for configuring build without X11
diff for ebuild 1.9.0 to honor the -X USE flag build.log of failed build |
Description
Vladimir Monchenko
2009-02-18 10:38:57 UTC
Excuse, has forgotten to specify that I instal mjpegtools on the computer without Xorg. Same here: >>> Emerging (8 of 11) media-video/mjpegtools-1.9.0 * mjpegtools-1.9.0.tar.gz RMD160 SHA1 SHA256 size ;-) ... [ ok ] * checking ebuild checksums ;-) ... [ ok ] * checking auxfile checksums ;-) ... [ ok ] * checking miscfile checksums ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking mjpegtools-1.9.0.tar.gz to /var/tmp/portage/media-video/mjpegtools-1.9.0/work >>> Source unpacked in /var/tmp/portage/media-video/mjpegtools-1.9.0/work >>> Compiling source in /var/tmp/portage/media-video/mjpegtools-1.9.0/work/mjpegtools-1.9.0 ... * econf: updating mjpegtools-1.9.0/config.guess with /usr/share/gnuconfig/config.guess * econf: updating mjpegtools-1.9.0/config.sub with /usr/share/gnuconfig/config.sub ./configure --prefix=/usr --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --without-x --disable-xfree-ext --without-libquicktime --with-libpng --without-v4l --without-gtk --without-sdl --without-libdv --disable-simd-accel --enable-largefile --without-jpeg-mmx --libdir=/usr/lib64 --build=x86_64-pc-linux-gnu [snip] checking for pthread_attr_getstacksize... yes checking for jpeg_start_compress in -ljpeg... yes checking for x86_64-pc-linux-gnu-pkg-config... no checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for LIBPNG... yes checking for X... disabled checking for __progname... yes checking for XF86DGAQueryExtension in -lXxf86dga... no checking for GTK... no checking for sdl-config... no checking for SDL - version >= 1.1.3... no *** The sdl-config script installed by SDL could not be found *** If SDL was installed in PREFIX, make sure PREFIX/bin is in *** your path, or set the SDL_CONFIG environment variable to the *** full path to sdl-config. checking Architecture... x86_64 checking sub-architecture settings... checking what warning flags to pass to the C compiler... -Wall -Wunused [snip] /usr/lib/gcc/x86_64-pc-linux-gnu/4.1.2/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lX11 Even if configured without X11, it tries to link in -lX11 :-(( . Created attachment 185344 [details, diff]
patch for configuring build without X11
I too want to build on a gentoo PC running without X (used as a htpc with DirectFB output only) and have to patch this all the time (like other packages, too...)
Created attachment 185346 [details, diff]
diff for ebuild 1.9.0 to honor the -X USE flag
(In reply to comment #4) > Created an attachment (id=185346) [edit] > diff for ebuild 1.9.0 to honor the -X USE flag > Thanks Lucian, build now works fine with your patches. Hi, could you please add this patch as soon as possible to the trunk and could you please also stabilize mjpegtools? Because someone closed #217427 (the problem is known there!!!) which results in a currently stable(!) broken mjpegtools. greez and tia Damage Conditional patching is no good. I see it has X_LIBS available, it should include -lX11 by itself... I saw this bug also during a new installation, with a world file copied from another box: mjpegtools-1.9.0 failed to build as described by the reporter because it was emerged before X was emerged, even though the default -X use flag was specified. mjpegtools-1.8.0-r2 built fine. Created attachment 201675 [details]
build.log of failed build
(In reply to comment #8) Same here - emerging of mjpegtools-1.9.0 (upgrading from mjpegtools-1.8.0-r1) fails due to missing libX11. Package seems to not fully honor -X use flag. mjpegtools-1.8.0-r2 emerges fine. Same here, also noted on new 1.9.0-r1 version. Culprit is an additional -lX11 in lavtools/Makefile.in. Removing that and rebuilding allows the installation to continue. My steps: * (emerge failed) * (go to /usr/portage/media-video/mjpegtools) * ebuild mjpegtools-1.9.0-r1.ebuild clean * ebuild mjpegtools-1.9.0-r1.ebuild unpack * vi /var/tmp/portage/media-video/mjpegtools-1.9.0-r1/work/mjpegtools-1.9.0/lavtools/Makefile.in * (remove the -lX11 around line 43 and save) * ebuild mjpegtools-1.9.0-r1.ebuild compile * ebuild mjpegtools-1.9.0-r1.ebuild install * ebuild mjpegtools-1.9.0-r1.ebuild postinst * ebuild mjpegtools-1.9.0-r1.ebuild qmerge There's probably a quicker way... This seems to be a simple change - let's please get this in so us headless folks can update the package without this hassle every release. Still not fixed in mjpegtools-1.9.0-r1. Has been failing since 2009, no response from maintainers -> USE="X" removed and forced --with-x The solution from comment 11 seems very much preferable to the one from comment 13. The latter loses the ability to install mjpegtools on headless systems. I.e. the regression relative to 1.8 is fixed by the former but not fixed by the latter method. It has never been possible, it has always been broken so converting this to low priority enchancement proposal then. I wouldn't expect anything to happen here anytime soon though, the existing 2 years should be indicator for that. *** This bug has been confirmed by popular vote. *** This should be fixed in mjpegtools-2.0.0_rc1 please reopen if there are still issues. |