Bug 257941

Summary:	gitosis-gentoo creation of git users from ebuild has git user account locked
Product:	Gentoo Linux	Reporter:	jon R-B <jon.roadleybattin>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED CANTFIX
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://git.overlays.gentoo.org/gitweb/?p=proj/gitosis-gentoo.git
Whiteboard:
Package list:		Runtime testing required:	---

Description jon R-B 2009-02-06 21:23:44 UTC

gitosis-gentoo (possibly gitosis as well) creates a user "git" to allow push/pull of repo's

HOWEVER the user is disabled by default

/etc/shadows
git:!:14281:0:99999:7::: 

initial "git clone git@HOST:gitosis-admin.git" fails.
git clone git@fluidGit:gitosis-admin.git
Initialized empty Git repository in /home/jrb/CODE/gitRepo/gitosis-admin/.git/
Permission denied (publickey).

entry in /var/log/auth.log
Feb  6 21:01:12 FluidServer sshd[19873]: User git not allowed because account is locked


changing the /etc/shadows entry to:
git:*:14281:0:99999:7::: 

Allows git user to function as expected

git clone git@fluidGit:gitosis-admin.git
Initialized empty Git repository in /home/jrb/CODE/gitRepo/gitosis-admin/.git/
Enter passphrase for key '/home/jrb/.ssh/jrb@FluidServer_git': 
Receiving objects: 100% (5/5), done.
remote: Counting objects: 5, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 5 (delta 0), reused 5 (delta 0)



Reproducible: Always

Comment 1 jon R-B 2009-02-06 21:57:44 UTC

I mean:

* : User cannot login by password
! : User cannot login to the system

Comment 2 Robin Johnson archtester

2009-05-15 09:51:24 UTC

There is no way to tell enewuser to not lock the user.
I added an information message instead.

Comment 3 jon R-B 2009-05-15 13:43:12 UTC

Thanks,

I have setup 3 gitosis systems and 2 of them I had to change the shadow entry so its not a hard and fast rule. 
I had a quick look in eutils w.r.t. enewuser and nothing sprang out 

an install message is probably the best thing