Summary: | net-fs/davfs2 issue with gcc 4.3.3 (_FORTIFY_SOURCE) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Darren Dale <dsdale24> |
Component: | New packages | Assignee: | Stefan Schweizer (RETIRED) <genstef> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | academic.sam, DarkNRG, mike, net-fs |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 259417 | ||
Attachments: |
Fix for compiling with gcc-4.3
Fixed early patch for compiling on gcc-4.3 patch to use only 0666 as mode |
Description
Darren Dale
2009-02-05 21:26:21 UTC
Created attachment 181166 [details, diff]
Fix for compiling with gcc-4.3
Here's a patch for the issue. O_CREAT is asking for another argument, I've supplied it with 0666. Should be fine. I also tried this on gcc-4.4 without the patch and it compiles fine. Created attachment 181168 [details, diff]
Fixed early patch for compiling on gcc-4.3
Must of still been asleep had the patch backwards. This is tested working now.
Patch compiles clean on gcc 4.1.2, 4.3, and 4.4 *** Bug 259003 has been marked as a duplicate of this bug. *** Created attachment 182107 [details, diff]
patch to use only 0666 as mode
Why do you put O_TRUNC into the third argument together with the mode?
Maybe the appended patch is a better approach.
(In reply to comment #3) > Created an attachment (id=181168) [edit] > Fixed early patch for compiling on gcc-4.3 > > Must of still been asleep had the patch backwards. This is tested working now. > Your patch is wrong it don't have 0666 in mode. DarkNRG patch looks okey for me but i would use IRUSR|IWUSR and add more if needed. + 01 Mar 2009; Patrick Lauer <patrick@gentoo.org> + +files/fortify_sources_fix.patch, davfs2-1.3.3.ebuild: + Fix for gcc 4.3.3 / fortify_sources, closes #257823. Patch by + <DarkNRG@gmx.de> *** Bug 272263 has been marked as a duplicate of this bug. *** |