| Summary: | media-sound/audacity-1.3.7 fails to compile | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Patrick Lauer <patrick> |
| Component: | New packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | erwan, graham, Martin.vGagern, pageexec |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Completely remove debug flag
Only remove after space Avoid overriding of debug and optimization flags |
||
|
Description
Patrick Lauer
2009-02-03 14:49:40 UTC
Same here. The aspect of the configuration which triggers this is the -ggdb flag in CXXFLAGS. The actual cause lies in lib-src/sbsms/configure{,.in}:
CXXFLAGS=`echo $CXXFLAGS | sed -e "s/-g//" -e "s/-O2//"`
This removes the "-g" of "-ggdb" without removing the "gdb". I'll write a patch.
Created attachment 180821 [details, diff]
Completely remove debug flag
This patch fixes the intention of the upstream configuration mechanism by completely removing the debug flag, even if it is "-ggdb" or similar instead of only "-g".
There is an un-Gentoo-ish feel to this manipulation of compiler flags. Maybe this whole line modifying the CXXFLAGS should be completely removed, so that the admin retains full control over compiler flags. But on the other hand, maybe there is a good reason for this line. I haven't investigated far enough to decide this yet.
Upstream changeset which introduced the CXXFLAGS modification: http://sbsms.svn.sourceforge.net/viewvc/sbsms?view=rev&revision=21 I just created a bug report for this upstream, maybe this can shed some light as to the intention of this CXXFLAGS modification as well: https://sourceforge.net/tracker2/?func=detail&aid=2561247&group_id=177794&atid=882654 It screws around with any flag, that has a '-g' inside, such as --param max-gcse-passes=N Created attachment 181233 [details, diff] Only remove after space (In reply to comment #3) > I just created a bug report for this upstream, maybe this can shed some light > as to the intention of this CXXFLAGS modification as well: > https://sourceforge.net/tracker2/?func=detail&aid=2561247&group_id=177794&atid=882654 No reaction yet. Looks like that tracker2 URL might not open directly without some kind of cookie, so you might want to use this URL instead: http://sourceforge.net/tracker/index.php?func=detail&aid=2561247&group_id=177794&atid=882654 (In reply to comment #4) > It screws around with any flag, that has a '-g' inside, such as --param > max-gcse-passes=N True. This patch might help to solve that problem. Not tested, though. Created attachment 181538 [details, diff]
Avoid overriding of debug and optimization flags
I had another look at the configure script. With debug disabled, CXXFKAGS is set to include -O3, so this is not one of the packages allergic to heavy optimization. On the other hand, both with and without debug enabled, the CXXFLAGS will be modified in some crucial way, affecting both debug code generation and code optimization.
This kind of customization, where a package (or part of a package like here) imposes flags, overriding those chosen by the system admin, for no discernible reason, is not how things should be in the Gentoo world.
The attached patch will remove a block of CXXFLAGS modifications, leaving settings for debug code generation and optimization as make.conf specifies them. audacity builds all right here with this patch in place.
(In reply to comment #6) > Created an attachment (id=181538) [edit] > Avoid overriding of debug and optimization flags I would consider that patch ready for inclusion into the portage tree. Unfortunately I'm not powerful enough to set the Inclusion keyword on this bug report here. Pleas include in any case. + 19 Feb 2009; Patrick Lauer <patrick@gentoo.org> + +files/audacity-1.3.7-cflags.patch: + Fixing bad CFLAG filtering by upstream. Patch by Martin von Gagern. Fixes + #257489 Thanks for the patch, upstream should be slapped for such broken CFLAG filtering. |