Bug 257335

Summary:	Cowloop fails to compile under 2.6.28
Product:	Gentoo Linux	Reporter:	Jérôme Poulin <jeromepoulin>
Component:	New packages	Assignee:	Daniel Black (RETIRED) <dragonheart>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	2008.0
Hardware:	All
OS:	Linux
URL:	http://www.atcomputing.nl/Tools/cowloop/home.html
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	cowloop-3.0-2.6.28.patch cowloop-3.0-r4.ebuild

Description Jérôme Poulin 2009-02-02 06:42:20 UTC

The summary sums it all, now here are the goodies.
Attached is a patch to make it compile under 2.6.28, I didn't test, however, under 2.6.27/26. If anyone would like to test so we can include #if, that would be appreciated.

Comment 1 Jérôme Poulin 2009-02-02 06:43:17 UTC

Created attachment 180659 [details, diff]
cowloop-3.0-2.6.28.patch

Makes cowloop compiles under 2.6.28 after all the other patches.

Comment 2 Jérôme Poulin 2009-02-02 06:44:07 UTC

Created attachment 180660 [details]
cowloop-3.0-r4.ebuild

This is the updated ebuild to include the patch plus changed arch to ~x86.

Comment 3 Daniel Black (RETIRED) gentoo-dev

2009-02-02 07:31:30 UTC

I assume you've tested the functionality and it work ok? Thanks for the patch - rarely see ones like this. I'll add it soon.

Comment 4 Jérôme Poulin 2009-02-02 07:38:49 UTC

I tested creating a cowdev, writing to it, deleting cowdev, examining the content of the cowfile, merging the cowfile, remounting it, everything is okay in the file. Then I tried rmmod'ing the module, seems like everything cleaned up correctly.
What is not tested is compatibility with 2.6.27 and 2.6.26, I guess there are probably 1 or 2 #IFs to add, but it may also work out-of-the-box.

Comment 5 Daniel Black (RETIRED) gentoo-dev

2009-02-02 12:24:48 UTC

all changes were 2.6.28 and not backwards compatible.
http://www.linuxhq.com/kernel/v2.6/28/fs/block_dev.c

I've done the #if magic and its hopefully right. I'll submit it upstream with credits to you.

thanks