Bug 254479 – games-emulation/nestopia (ebuild request)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Yaroslav Isakov 2009-01-10 20:46:48 UTC]

There is port of NEStopia NES emulator, so I wish to see this in Gentoo

[Comment 1 Michał Ziąbkowski 2009-01-18 19:09:48 UTC]

Created attachment 178903 [details]
nestopia 1.40 ebuild from roslin uberlay

Attaching my nestopia ebuild from roslin. Since the user is expected to copy some files by hand for the emu to work, I made a simple wrapper which does precisely that. Also, rbelmont's webhost blocks wget. Hence the fetch restriction.

[Comment 2 Michał Ziąbkowski 2009-01-18 19:11:19 UTC]

Created attachment 178906 [details]
nestopia wrapper

[Comment 3 Yaroslav Isakov 2009-01-18 19:14:32 UTC]

Thanks!

[Comment 4 Michał Ziąbkowski 2009-01-23 21:28:40 UTC]

Created attachment 179477 [details]
Updated ebuild, fixed html docs

[Comment 5 SpanKY 2010-01-19 18:13:57 UTC]

for the wrapper:
 - add quotes around the games datadir
 - use "$@" and not $@ -- the difference is subtle but important

for the ebuild:
 - you have too many tabs in everything ... only use one to indent
 - add '|| die' to the data/bin install

[Comment 6 Jared B. 2010-01-21 06:53:22 UTC]

updated ebuild and wrapper.  I wasn't quite sure what you meant by "add '|| die' to the data/bin install", so I added || die conditions to the doins and newgamesbin lines.  I can change either of those if that wasn't correct.

Any other issues that need to be corrected?

[Comment 7 Jared B. 2010-01-21 06:53:56 UTC]

Created attachment 217042 [details]
updated ebuild

[Comment 8 Jared B. 2010-01-21 06:54:16 UTC]

Created attachment 217043 [details]
updated wrapper

[Comment 9 SpanKY 2010-01-21 08:38:56 UTC]

that is what i meant, thanks

more things i noticed:
 - drop the RESTRICT=fetch and pkg_nofetch
 - the wrapper install is a little dicey ... better to do:
dogamesbin "${FILESDIR}"/${PN} || die
dosed "s:%GAMES_DATADIR%:${GAMES_DATADIR}:g" "${GAMES_BINDIR}/${PN}"

[Comment 10 Michał Ziąbkowski 2010-01-21 15:30:14 UTC]

Created attachment 217088 [details]
Dropped pkg_nofetch and tweaked wrapper install

I see someone beat me to the punch :)

Uploaded an updated ebuild with most suggestions applied, except RESTRICT=fetch. Upstream doesn't like wget. One of the files would need to be mirrored.

Moreover, someone enlightened enough should look into fixing the build system, so -j1 can be dropped.

[Comment 11 Mr. Bones. (RETIRED) 2010-01-21 16:31:54 UTC]

The wrapper should be created in src_prepare and simply installed in src_install.

[Comment 12 Michał Ziąbkowski 2010-01-22 14:13:26 UTC]

Created attachment 217168 [details]
New ebuild

Okay, went back from dosed to using sed, moved it to src_prepare. Dropped the -j1, since the build seems to work just fine without it (compiled it several times with -j2 and -j5). Added desktop entry. Anything else you want me to change?

[Comment 13 SpanKY 2010-01-24 01:54:30 UTC]

dosed is really on valid in src_install as it operates on $D.  i dont have a problem with pulling from $FILESDIR in src_install.  i.e. either method is fine.

the latest ebuilds look OK to me (not that i've directly tested them)

[Comment 14 Mr. Bones. (RETIRED) 2010-01-24 07:51:52 UTC]

in portage.  thanks for the bug report and file submissions.