Bug 253405

Summary:	sys-apps/portage: disabled entries should be filtered from p.mask comments
Product:	Portage Development	Reporter:	Dolores <boltomli>
Component:	Core - Interface (emerge)	Assignee:	Portage team <dev-portage>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	mmokrejs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Dolores 2009-01-02 02:33:02 UTC

portage.mask:
>sys-power/pm-utils-0.99.4
#>x11-misc/qterm-0.5.2-r1
=app-misc/screen-9999-r1
>sys-libs/libraw1394-1.2.1
net-www/mplayerplug-in




Reproducible: Always

Steps to Reproduce:
emerge -uDN world
Actual Results:  
!!! The following installed packages are masked:
- net-www/mplayerplug-in-3.50 (masked by: package.mask)
/etc/portage/package.mask:
#>x11-misc/qterm-0.5.2-r1

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.

Expected Results:  
!!! The following installed packages are masked:
- net-www/mplayerplug-in-3.50 (masked by: package.mask)
/etc/portage/package.mask:
net-www/mplayerplug-in

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.

Comment 1 Andrew Gaffney (RETIRED) gentoo-dev

2009-01-02 02:43:42 UTC

Portage is trying to apply the same code it uses to find the comment with the reason for the mask in the profile package.mask to the user-created package.mask. It's not really doing anything "wrong" here.

Perhaps portage could just ignore comments that look like they have atoms after the #, but that just adds more overhead, and I really don't think it's necessary.

Comment 2 Marius Mauch (RETIRED) gentoo-dev

2009-01-02 12:16:38 UTC

It's working as intended. As for filtering, that's tricky as comments can also contain atoms for description purposes (including on separate lines), and it's hard to draw the line in some cases, e.g.

# masked because it depends on the not-yet stable
# >cat/foo-2:
#>cat/bar-1.2
=cat/bar-2*

So at best I'd say filtering should only match comments that ONLY contain atoms.

Comment 3 Sebastian Luther (few) 2011-09-20 17:58:36 UTC

*** Bug 261858 has been marked as a duplicate of this bug. ***

Comment 4 Zac Medico gentoo-dev

2011-09-20 18:06:01 UTC

Simply add a blank line after you comment out an atom, to separate it from other comments.