Bug 252698 – sys-devel/gcc-3.3.6-r1 should replace more cpu flags

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Le retraité 2008-12-27 14:56:53 UTC]

In the current portage gcc-3.3.6-r1 ebuild, there is 'replace-cpu-flags k8 athlon64 opteron i686'. But for amd64 and x86, more cpu flags should be replaced (such as pentium-m in my case)

[Comment 1 SpanKY 2009-02-15 23:04:13 UTC]

fixed in cvs, thanks

http://sources.gentoo.org/eclass/toolchain.eclass?r1=1.389&r2=1.390

[Comment 2 Le retraité 2009-02-16 14:05:39 UTC]

Reopening, explaining why in the next message (with my new account)

[Comment 3 Jonathan-Christofer Demay 2009-02-16 14:07:41 UTC]

Worked greate for my old pentium-m pc, thanks ! However, last week I bought a core2, can you add core2 to replace-cpu-flags in eclass/toolchain.eclass ?

[Comment 4 Jonathan-Christofer Demay 2009-02-16 20:47:49 UTC]

mmmh... according to this:
http://en.gentoo-wiki.com/wiki/Safe_Cflags/Intel#Intel_Core_2_Duo.2FQuad_.2F_Xeon_51xx.2F53xx.2F54xx.2C_Pentium_Dual-Core_T23xx.2B.2FExxxx

I think toolchain.eclass should be patched this way:
--- toolchain.eclass	2009-02-16 12:10:07.000000000 +0000
+++ /usr/portage/eclass/toolchain.eclass	2009-02-16 12:16:42.000000000 +0000
@@ -1558,6 +1558,10 @@
 		replace-cpu-flags k8 athlon64 opteron i686
 		replace-cpu-flags pentium-m pentium3m pentium3
 		case $(tc-arch) in
+			amd64) replace-cpu-flags core2 nocona;;
+			x86)   replace-cpu-flags core2 prescott;;
+		esac
+		case $(tc-arch) in
 			amd64|x86) filter-flags '-mtune=*';;
 		esac
 		;;

[Comment 5 Jonathan-Christofer Demay 2009-02-18 09:21:30 UTC]

You may also add this:
	replace-cpu-flags G3 750
	replace-cpu-flags G4 7400
	replace-cpu-flags G5 7400

from http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-libs/libstdc%2B%2B-v3/libstdc%2B%2B-v3-3.3.6.ebuild?rev=1.24

[Comment 6 Mark Loeser (RETIRED) 2009-05-02 02:08:57 UTC]

These all seem to be in the eclass already, but this wasn't closed.