Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 252028

Summary: net-print/magicfilter: pre-stripped files found
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Printing Team <printing>
Status: RESOLVED FIXED    
Severity: QA    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 239866    

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-21 21:36:42 UTC
net-print/magicfilter-2.3d:20081218-221133.log:  * QA Notice: Pre-stripped files found:
net-print/magicfilter-2.3d:20081218-221133.log:  * /var/tmp/portage/net-print/magicfilter-2.3d/image/usr/share/magicfilter/filters/textonly
net-print/magicfilter-2.3d:20081218-221133.log:  * /var/tmp/portage/net-print/magicfilter-2.3d/image/usr/bin/magicfilter

Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Thanks,
Diego
Comment 1 Kevin Pyle 2009-06-09 22:46:00 UTC
In addition to premature stripping, this package uses a custom configure script that incorrectly chokes on valid LDFLAGS and, left unguided, uses /usr/bin/cc as the C compiler of choice.  Based on inspection, exporting CC will override the search logic.  The LDFLAGS check tries to feed a finished ELF executable back into the linker for linking, then reports failure when the linker rejects it.

Additionally, the ebuild is a bit strange.  It passes ${D} to the --prefix for the configure script, causing the package to record the installation area in its Makefile.  The ebuild directs the package to install using DESTDIR, but the Makefile does not support DESTDIR.  It appears that installation only works because of the incorrect usage of ${D} in --prefix.

Finally, there have been several minor releases upstream since the latest version in Portage, but no one has asked for a version bump.  The last modified time on the most recent release is Wed, 05 Apr 2006 23:27:56 GMT.  This appears to be a leaf package, too.  None of these QA issues is particularly hard to fix, but I wonder if anyone actually uses this package.  Maintainers, is this a candidate for treecleaning?
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2009-10-17 23:35:58 UTC
All issues fixed in magicfilter-2.3h.