Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 251926

Summary: dev-scheme/scm: pre-stripped files found
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Scheme Project <scheme>
Status: RESOLVED FIXED    
Severity: QA CC: chtof62, vadimk
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 239866    
Attachments: proposed fix for the pre-stripped
diff scm-5.5.4.ebuild scm-5.5.4-r1.ebuild
source patch
scm-5.5.4.ebuild.diff (Corrected ebuild)
scm-5.5.5.ebuild.diff (Corrected ebuild - Also concerned by this bug)
scm-5.5.5-r1.ebuild.diff (Corrected ebuild - Also concerned by this bug)
scm-5.5.5.ebuild.diff (Corrected ebuild - Also concerned by this bug)
scm-5.5.5-r1.ebuild.diff (Corrected ebuild - Also concerned by this bug)

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-21 19:31:55 UTC
dev-scheme/scm-5.5.4:20081214-114341.log:  * QA Notice: Pre-stripped files found:
dev-scheme/scm-5.5.4:20081214-114341.log:  * /var/tmp/portage/dev-scheme/scm-5.5.4/image/usr/bin/scmlit

Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Thanks,
Diego
Comment 1 Vadim Kuznetsov (RETIRED) gentoo-dev 2009-01-08 17:32:08 UTC
Created attachment 177775 [details]
proposed fix for the pre-stripped

I've rewrote src_unpack(), moving changes to Makefile into patch file (files/scm-5.5.4-gentoo.patch). pre-stripping was fixed there.
I've also rewrote src_compile() and added dependencies required for DLLs. I'm not entirely comfortable with termcap library. After installing sys-libs/libtermcap-compat /lib/libtermcap.so was missinig. I had to creat it like that: ln -s /lib/libtermcap.so.2 /lib/libtermcap.so

Thanks,
Vadim.
Comment 2 Vadim Kuznetsov (RETIRED) gentoo-dev 2009-01-12 16:01:21 UTC
Created attachment 178186 [details]
diff  scm-5.5.4.ebuild scm-5.5.4-r1.ebuild
Comment 3 Vadim Kuznetsov (RETIRED) gentoo-dev 2009-01-12 16:02:41 UTC
Created attachment 178188 [details, diff]
source patch
Comment 4 Marijn Schouten (RETIRED) gentoo-dev 2009-02-02 22:33:49 UTC
this does not apply cleanly to scm-5.5.5 and has lots of unrelated changes.
Comment 5 Christophe LEFEBVRE 2010-03-12 23:27:13 UTC
Created attachment 223341 [details, diff]
scm-5.5.4.ebuild.diff (Corrected ebuild)
Comment 6 Christophe LEFEBVRE 2010-03-12 23:28:03 UTC
Created attachment 223343 [details, diff]
scm-5.5.5.ebuild.diff (Corrected ebuild - Also concerned by this bug)
Comment 7 Christophe LEFEBVRE 2010-03-12 23:28:26 UTC
Created attachment 223345 [details, diff]
scm-5.5.5-r1.ebuild.diff (Corrected ebuild - Also concerned by this bug)
Comment 8 Christophe LEFEBVRE 2010-03-12 23:36:58 UTC
Created attachment 223347 [details, diff]
scm-5.5.5.ebuild.diff (Corrected ebuild - Also concerned by this bug)
Comment 9 Christophe LEFEBVRE 2010-03-12 23:37:26 UTC
Created attachment 223349 [details, diff]
scm-5.5.5-r1.ebuild.diff (Corrected ebuild - Also concerned by this bug)
Comment 10 Tomás Touceda (RETIRED) gentoo-dev 2010-04-28 13:30:23 UTC
I'm closing this bug since scm-5.5.6 is the only version in main tree and the stripping's patched.

Thanks everyone for the patches.