Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 251859

Summary: app-misc/fdutils: pre-stripped files found
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Gentoo Kernel Miscellaneous <kernel-misc>
Status: RESOLVED FIXED    
Severity: QA CC: gentoo.8eaf7cd8e5128d8191fe
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 239866    
Attachments: Patch to fdutils-5.5.ebuild to add a sed call to prevent premature stripping

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-21 13:39:32 UTC
Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Thanks,
Diego

app-misc/fdutils-5.5:20081212-033132.log:  * QA Notice: Pre-stripped files found:
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/floppycontrol
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/fdrawcmd
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/xdfcopy
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/setfdprm
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/getfdprm
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/diskseekd
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/superformat
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/fdmount
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/floppymeter
app-misc/fdutils-5.5:20081212-033132.log:  * /var/tmp/portage/app-misc/fdutils-5.5/image/usr/bin/diskd
Comment 1 Kevin Pyle 2009-02-14 17:58:25 UTC
Created attachment 182031 [details, diff]
Patch to fdutils-5.5.ebuild to add a sed call to prevent premature stripping

The upstream src/Makefile.in includes an explicit -s in its call to $(INSTALL).  This patch adds a sed call to match those lines and remove the -s.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-01-10 09:48:59 UTC
fixed. Thanks for the patch kyle.