Bug 250750 – new package dev-util/colorsvn

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Henning Schild 2008-12-12 19:40:57 UTC]

This perl script colorizes subversion.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Henning Schild 2008-12-12 19:41:46 UTC]

Created attachment 175135 [details]
dev-util/colorsvn/colorsvn-0.3.2.ebuild

[Comment 2 Serkan Kaba (RETIRED) 2008-12-15 08:54:18 UTC]

(In reply to comment #1)
> Created an attachment (id=175135) [edit]
> dev-util/colorsvn/colorsvn-0.3.2.ebuild
> 

The ebuild can utilize the standard tools (configure, make) to configure and install the package.
Looking at the code the ebuild seems to miss "virtual/perl-Term-ANSIColor" dependency.

[Comment 3 Henning Schild 2008-12-15 12:37:40 UTC]

(In reply to comment #2)
> The ebuild can utilize the standard tools (configure, make) to configure and
> install the package.

For configuration the ebuild relies on these tools. The install target violated the sandbox so i decided to implement it like i did. The alternative would be do dig for the problem and patch it away. The ebuild was inspired by the ebuild for colorgcc.

> Looking at the code the ebuild seems to miss "virtual/perl-Term-ANSIColor"
> dependency.

Well it does not. Both libs used by the script are provided by dev-lang/perl-5.8.8-r5.

Looking at this virtual ebuild it looks to me like it asumes Term::ANSIColor to be part of perl-5.10 but no other version, could this also be a bug? This asumption is clearly wrong since i use colorsvn on two boxes where perl-core/Term-ANSIColor is not installed but provided by dev-lang/perl.

[Comment 4 Serkan Kaba (RETIRED) 2008-12-15 14:32:27 UTC]

(In reply to comment #3)
> (In reply to comment #2)
> > Looking at the code the ebuild seems to miss "virtual/perl-Term-ANSIColor"
> > dependency.
> 
> Well it does not. Both libs used by the script are provided by
> dev-lang/perl-5.8.8-r5.
> 
> Looking at this virtual ebuild it looks to me like it asumes Term::ANSIColor to
> be part of perl-5.10 but no other version, could this also be a bug? This
> asumption is clearly wrong since i use colorsvn on two boxes where
> perl-core/Term-ANSIColor is not installed but provided by dev-lang/perl.
> 
Perl, can you investigate this?

[Comment 5 Torsten Veller (RETIRED) 2008-12-15 15:21:48 UTC]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Looking at the code the ebuild seems to miss "virtual/perl-Term-ANSIColor"
> > > dependency.
> > 
> > Well it does not. Both libs used by the script are provided by
> > dev-lang/perl-5.8.8-r5.
> > 
> > Looking at this virtual ebuild it looks to me like it asumes Term::ANSIColor to
> > be part of perl-5.10 but no other version, could this also be a bug? This
> > asumption is clearly wrong since i use colorsvn on two boxes where
> > perl-core/Term-ANSIColor is not installed but provided by dev-lang/perl.
> > 
> Perl, can you investigate this?

Not much to investigate here. It's a problem of perl modules in gentoo.
If a package uses a dual-lifed module, it should depend on the virtual.
(This is really boring with packages using Test::Simple or Test::More in their tests.)

| Term::ANSIColor was first released with perl 5.006
|[...]
|    5.008008   1.10
|    5.01       1.12

So version 1.12 is provided by perl-5.10.0 or by Term-ANSIColor-1.12.
This is what the virtual/perl-Term-ANSIColor says:
RDEPEND="|| ( ~dev-lang/perl-5.10.0 ~perl-core/Term-ANSIColor-${PV} )"

Even if there would be a virtual/perl-Term-ANSIColor-1.10 which depends on perl-5.8.8 only, your package manager would install virtual/perl-Term-ANSIColor-1.12 (the best visible version).

If I am wrong, please correct me.
If anyone wants to discuss this in general, please move it to a more reasonable place (irc:#gentoo-perl, or gentoo-perl@l.g.o).

[Comment 6 Christian Ruppert (idl0r) 2008-12-15 17:14:05 UTC]

Created attachment 175347 [details]
colorsvn-0.3.2.ebuild

improved ebuild for dev-util/colorsvn. (should avoid sandbox violations.)

"zsh/2 1016 % qfile -v ANSIColor.pm   
dev-lang/perl-5.8.8-r5 (/usr/lib64/perl5/5.8.8/Term/ANSIColor.pm)"

so i think there is no need to include it in RDEPEND.
or should we include the virtual of ansicolor?

[Comment 7 Serkan Kaba (RETIRED) 2008-12-16 07:16:02 UTC]

(In reply to comment #6)
> Created an attachment (id=175347) [edit]
> colorsvn-0.3.2.ebuild
> 
> improved ebuild for dev-util/colorsvn. (should avoid sandbox violations.)
This misses perl dependency.
> 
> "zsh/2 1016 % qfile -v ANSIColor.pm   
> dev-lang/perl-5.8.8-r5 (/usr/lib64/perl5/5.8.8/Term/ANSIColor.pm)"
> 
> so i think there is no need to include it in RDEPEND.
> or should we include the virtual of ansicolor?
> 

Perl, what's your final suggestion about it?

[Comment 8 Christian Ruppert (idl0r) 2008-12-16 09:43:54 UTC]

(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=175347) [edit]
> > colorsvn-0.3.2.ebuild
> > 
> > improved ebuild for dev-util/colorsvn. (should avoid sandbox violations.)
> This misses perl dependency.
you're right perl should be listed.
> > 
> > "zsh/2 1016 % qfile -v ANSIColor.pm   
> > dev-lang/perl-5.8.8-r5 (/usr/lib64/perl5/5.8.8/Term/ANSIColor.pm)"
> > 
> > so i think there is no need to include it in RDEPEND.
> > or should we include the virtual of ansicolor?
> > 
> 
> Perl, what's your final suggestion about it?
> 

just depend on perl should be ok then.
TERM::ANSIColor is provided by perl 5.x.

[Comment 9 Christian Ruppert (idl0r) 2009-01-10 10:24:35 UTC]

Now available in the Sunrise overlay: http://overlays.gentoo.org/proj/sunrise/browser/reviewed/dev-util/colorsvn

[Comment 10 Christian Ruppert (idl0r) 2009-03-10 00:57:40 UTC]

+*colorsvn-0.3.2 (10 Mar 2009)
+
+  10 Mar 2009; Christian Ruppert (idl0r) <[e-mail]> +metadata.xml,
+  +colorsvn-0.3.2.ebuild:
+  New ebuild for bug 250750 thanks to Henning Schild

Thanks!