Bug 25055 – Frozen-Bubble does not install itself as a game

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description bugs 2003-07-22 07:05:53 UTC]

By which I mean it does not place the binary under /usr/games/bin with group
and/or user of games and permissions of 750

Most other games do this and I happen to like it for organization and restriction.

Reproducible: Always
Steps to Reproduce:

[Comment 1 Ian Leitch (RETIRED) 2003-07-22 09:40:56 UTC]

frozen-bubble uses a make file to handle is installation. The correct way to do what you are asking is to patch the make file. I'll look into it.

[Comment 2 Chris Gianelloni (RETIRED) 2003-07-22 10:22:06 UTC]

Actually, there should be no need to change anything in the Makefile, but rather to use the functions in the games.eclass to modify the destination locations.  Also, simply overriding variables works quite a bit cleaner than patching the Makefile.  It also keeps us from having to maintain patches that are not necessary.

[Comment 3 Ian Leitch (RETIRED) 2003-07-22 10:29:18 UTC]

If we override a variable (${BINDIR}) we end up with frozen-bubble-editor in /usr/games/bin aswell. IMO frozen-bubble-editor should stay in /usr/bin.

[Comment 4 Ian Leitch (RETIRED) 2003-07-22 10:48:11 UTC]

Created attachment 14874 [details, diff]
ebuild patch

[Comment 5 Ian Leitch (RETIRED) 2003-07-22 10:49:40 UTC]

Created attachment 14875 [details, diff]
usr-games-bin-gentoo.patch

This patch creates a new variable for the installation location of
frozen-bubble. It still makes use of ${PREFIX}.

[Comment 6 Chris Gianelloni (RETIRED) 2003-07-22 11:19:37 UTC]

The purpose of the games.eclass stuff is actually to keep all parts of the game in /usr/games, as it should be.  The editor is no exception.  We therefore need no patch whatsoever to the original sources of the game.

I am updating the ~arch version of the ebuild in CVS.  It should be on the mirrors shortly.  Since I am not changing a stable version, I am not going to bump the revision.  If you wish to use the updated ebuild, simply emerge sync && emerge frozen-bubble again.

[Comment 7 bugs 2003-07-23 07:35:02 UTC]

Thanks guys!
That was fast :)

[Comment 8 TGL 2003-07-23 17:26:05 UTC]

Created attachment 14942 [details]
frozen-bubble-1.0.0-r2.ebuild

The current ebuild is not perfect yet: "games.eclass" specifies
/usr/share/games for data files, whereas they were installed in
/usr/games/share. Here is a corrected version.