| Summary: | sys-process/lsof-4.81-r2 fails to build on freebsd (recursive make with gnumake issue) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Alexis Ballier <aballier> |
| Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bsd+disabled |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | FreeBSD | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
add proper header info and it should be fine to commit http://dev.gentoo.org/~vapier/clean-patches (In reply to comment #1) > add proper header info and it should be fine to commit > > http://dev.gentoo.org/~vapier/clean-patches info added and committed. |
It calls make directly for a recursive make call what causes issues for us as we're using gnu make by default. Trivial fix: --- lsof_4.81/lsof_4.81_src/dialects/freebsd/Makefile.old 2008-12-09 12:56:40 +0000 +++ lsof_4.81/lsof_4.81_src/dialects/freebsd/Makefile 2008-12-09 12:56:48 +0000 @@ -129,7 +129,7 @@ dnode2.o: dzfs.h dnode2.c @if [ -f ./Makefile.zfs ]; then \ - make -f Makefile.zfs dnode2.o; \ + ${MAKE} -f Makefile.zfs dnode2.o; \ else \ echo "${CC} ${CFLAGS} -c dnode2.c"; \ ${CC} ${CFLAGS} -c dnode2.c; \ I've already mailed it upstream as noted in the bug report section of the readme, now the question is: would you mind if i apply it once i have a (positive) answer from upstream?