Bug 250271

Summary:	net-analyzer/nagstamon could depend on fewer GNOME packages
Product:	Gentoo Linux	Reporter:	Robin Atwood <robin.atwood>
Component:	New packages	Assignee:	Tobias Scherbaum (RETIRED) <dertobi123>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	netmon
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Modified ebuild Diff for ebuild Nagstamon desktop file

Description Robin Atwood 2008-12-08 12:05:39 UTC

Nagstamon is a useful little application and I wrote my own ebuild for it awhile ago, so it is good to see it in the official Portage tree. However, the dependencies cause a lot of the Gnome desktop to be dragged in which is a bit of an overkill for KDE-only users. Also, it gets you no extra functionality since the status bar in systray option is only available for Gnome. I have uploaded an ebuild with a USE flag to fix this problem; it is a synthesis of my original ebuild and the official one. HTH!

Reproducible: Always

Steps to Reproduce:
1.emerge -pv nagstamon on a -gnome system.
2.
3.

Actual Results:  
# emerge -pv nagstamon

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N    ] dev-libs/gdl-0.7.6  USE="-debug -gnome" 439 kB [0]
[ebuild  N    ] gnome-extra/gtkhtml-2.11.1  USE="-accessibility -debug -test" 584 kB [0]
[ebuild  N    ] gnome-base/libgtop-2.22.3  USE="-debug" 759 kB [0]
[ebuild  N    ] dev-python/pyorbit-2.14.3  USE="-debug" 278 kB [0]
[ebuild  N    ] app-text/enchant-1.3.0  527 kB [0]
[ebuild  N    ] app-text/gtkspell-2.0.14  USE="-doc" 375 kB [0]
[ebuild  N    ] dev-python/gnome-python-2.22.0  USE="-debug -doc -examples" 527 kB [0]
[ebuild  N    ] x11-libs/libgksu-2.0.5  USE="nls -debug -doc" 486 kB [0]
[ebuild  N    ] dev-python/gnome-python-extras-2.19.1-r2  USE="X -debug -doc -firefox -seamonkey -xulrunner" 354 kB [0]
[ebuild   R   ] net-analyzer/nagstamon-0.6.2  USE="(-kde%*)" 0 kB [1=>0]

Total: 10 packages (9 new, 1 reinstall), Size of downloads: 4,325 kB
Portage tree and overlays:
 [0] /usr/portage
 [1] /usr/local/portage


Expected Results:  
Not had a dependency on dev-python/gnome-python-extras on KDE-only systems.

Comment 1 Robin Atwood 2008-12-08 12:07:45 UTC

Created attachment 174635 [details]
Modified ebuild

My ebuild also includes an nagstamon.desktop for the convenience of the users.

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2008-12-09 02:20:17 UTC

Ew, it would be better if you had simply attached a unified diff for easy review instead of a complete tarball.

Comment 3 Robin Atwood 2008-12-09 10:33:27 UTC

The idea was that the tarball could be unpacked into a local overlay. However, two new files uploaded.

Comment 4 Robin Atwood 2008-12-09 10:34:11 UTC

Created attachment 174701 [details, diff]
Diff for ebuild

Comment 5 Robin Atwood 2008-12-09 10:36:25 UTC

Created attachment 174703 [details]
Nagstamon desktop file

Comment 6 Tobias Scherbaum (RETIRED) gentoo-dev

2008-12-09 18:29:01 UTC

Thanks for your patches, Robin! I added nagstamon-0.6.2-r1 based on upon your patches.

Some quick notes:
I'd choose to name the use-flag "gnome" instead of kde - we do enable (optional) things for Gnome users, not disable gnome-stuff for KDE users. As deps for Gnome both dev-python/gnome-python-extras and dev-python/egg-python will provide the used python libs, changed the deps accordingly.
The desktop file you provided didn't work for me on a Gnome desktop as it used an invalid format. You can easily check those syntax failures with running "repoman full" (after redigesting) in the ebuild directory.

Thanks, Robin!

Comment 7 Robin Atwood 2008-12-09 22:17:25 UTC

I thought the xxx.desktop format was supposed to be desktop-neutral, but there you go. Glad to be of help.