Bug 248345

Summary:	sci-chemistry/mpqc: fails with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Justin Lecher (RETIRED) <jlec>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, markusle, sci-chemistry, xarthisius
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log adding epatch fixing as-needed issues adding patches and mpi support fixing as-needed issues making build system respect ldflags fixing undefined reference to libs during test phase

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-11-23 15:30:11 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-11-23 15:30:44 UTC

Created attachment 172954 [details]
Build log

Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-02-13 13:54:49 UTC

Created attachment 219419 [details, diff]
adding epatch

Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-02-13 13:55:39 UTC

Created attachment 219421 [details, diff]
fixing as-needed issues

Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-02-14 10:20:19 UTC

Created attachment 219601 [details, diff]
adding patches and mpi support

Summary of changes:
 * EAPI=2 bump (for use dep virtual/mpi[cxx])
 * adding mpi support, (build system used mpi by default when it was autodetected)
 * adding patch to respect LDFLAGS (autoreconf needed)

Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-02-14 10:20:54 UTC

Created attachment 219603 [details, diff]
fixing as-needed issues

Comment 6 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-02-14 10:22:09 UTC

Created attachment 219605 [details, diff]
making build system respect ldflags

few other changes are also done by as-needed patch, maybe those two should be merged?

Comment 7 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-02-14 10:24:47 UTC

Created attachment 219607 [details, diff]
fixing undefined reference to libs during test phase

This dirty hack rather than fix. Wrapper for binary program mpqc created during build phase, fails to find freshly compiled libraries, despite the fact it is linked to the proper '.la' files.

Comment 8 Markus Dittrich (RETIRED) gentoo-dev

2010-02-19 05:17:45 UTC

(In reply to comment #7)
> Created an attachment (id=219607) [details]
> fixing undefined reference to libs during test phase
> 
> This dirty hack rather than fix. Wrapper for binary program mpqc created during
> build phase, fails to find freshly compiled libraries, despite the fact it is
> linked to the proper '.la' files. 
> 

Great, thanks a lot! I'll have a look at this as soon as I find some time.

Best,
Markus

Comment 9 Justin Lecher (RETIRED) gentoo-dev

2010-02-19 07:11:03 UTC

I tested that stuff but didn't commit it. Should I do it Markus or do you do it?

Comment 10 Markus Dittrich (RETIRED) gentoo-dev

2010-02-27 03:42:52 UTC

(In reply to comment #9)
> I tested that stuff but didn't commit it. Should I do it Markus or do you do
> it?
> 

Please go ahead and thanks in advance :)

cheers,
Markus

Comment 11 Justin Lecher (RETIRED) gentoo-dev

2010-05-23 10:39:48 UTC

+*mpqc-2.3.1-r2 (23 May 2010)
+
+  23 May 2010; Justin Lecher <jlec@gentoo.org> mpqc-2.3.1-r1.ebuild,
+  +mpqc-2.3.1-r2.ebuild, +files/mpqc-2.3.1-as-needed.patch,
+  +files/mpqc-2.3.1-respect-ldflags.patch,
+  +files/mpqc-2.3.1-test-failure-hack.patch:
+  Fix for bug 248345, as-needed related, thanks Kacper Kowalik (Xarthisius)
+  for makeing the patches
+