Bug 248252

Summary:	app-emmulation/kvm-79 needs tweaking on patch file kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch
Product:	Gentoo Linux	Reporter:	Fabio Coatti <fabio.coatti>
Component:	Current packages	Assignee:	Daniel Gryniewicz (RETIRED) <dang>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cardoe
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Fabio Coatti 2008-11-22 21:48:16 UTC

kvm-79 adds another point in wich the network script is defined. To me this seems weird enough, but see this:
kefk work # grep -r DEFAULT_NETWORK_SCRIPT .
./kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch:-#define DEFAULT_NETWORK_SCRIPT "/etc/qemu-ifup"
./kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch:+#define DEFAULT_NETWORK_SCRIPT "/etc/kvm/kvm-ifup"
./kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch:            DEFAULT_NETWORK_SCRIPT,
./kvm-79/qemu/vl.c:#define DEFAULT_NETWORK_SCRIPT "/etc/kvm/kvm-ifup"
./kvm-79/qemu/vl.c:           DEFAULT_NETWORK_SCRIPT,
./kvm-79/qemu/net.c:#define DEFAULT_NETWORK_SCRIPT "/etc/qemu-ifup"
./kvm-79/qemu/net.c:                pstrcpy(setup_script, sizeof(setup_script), DEFAULT_NETWORK_SCRIPT);


while kvm-78 is a different story:
kefk work # grep -r DEFAULT_NETWORK_SCRIPT .
./kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch:-#define DEFAULT_NETWORK_SCRIPT "/etc/qemu-ifup"
./kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch:+#define DEFAULT_NETWORK_SCRIPT "/etc/kvm/kvm-ifup"
./kvm-patches-20081106/02_all_qemu-kvm-cmdline.patch:            DEFAULT_NETWORK_SCRIPT,
./kvm-78/qemu/vl.c:#define DEFAULT_NETWORK_SCRIPT "/etc/kvm/kvm-ifup"
./kvm-78/qemu/vl.c:                pstrcpy(setup_script, sizeof(setup_script), DEFAULT_NETWORK_SCRIPT);
./kvm-78/qemu/vl.c:           DEFAULT_NETWORK_SCRIPT,


basically, a net.c appeared and messed up the patch and startup script. To me make sense that this define appears only once, but that's the situation.




Reproducible: Always

Steps to Reproduce:
emerge =kvm-79
Actual Results:  
the package gets installed, but look here:
kefk kvm # kvm -m 1GM /opt/kvm/image.qcow2 -net nic,macaddr=DE:AD:BE:EF:15:5 -net tap -
/etc/qemu-ifup: could not launch network script
Could not initialize device 'tap'


Expected Results:  
kvm startup

Comment 1 Daniel Gryniewicz (RETIRED) gentoo-dev

2008-11-25 15:52:28 UTC

I've pushed a new 79 with a new patch tarball fixing this.