Bug 247190

Summary:	dev-tcltk/tclpython-4.1 does not respect LDFLAGS and is not working... (fix suggested)
Product:	Gentoo Linux	Reporter:	Peter Volkov (RETIRED) <pva>
Component:	Current packages	Assignee:	TCL/TK Project <tcltk>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933

Description Peter Volkov (RETIRED) gentoo-dev

2008-11-17 13:24:34 UTC

dev-tcltk/tclpython-4.1 does not respect LDFLAGS

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/lib/tclpython/tclpython.so.4.1

Also I found rather strange the following:
>>> Compiling source in /var/tmp/portage/dev-tcltk/tclpython-4.1/work/tclpython-4.1 ...
Usage: /usr/bin/python-config [--prefix|--exec-prefix|--includes|--libs|--cflags|--ldflags|--help]
>>> Source compiled.

This Usage: ... line looks like something is not working, but I'm not sure.

Comment 1 Peter Volkov (RETIRED) gentoo-dev

2008-11-18 18:00:54 UTC

Well, now I'm sure it's not working:

camobap-unstable ~ # tclsh
% package require tclpython
couldn't load file "/usr/lib/tclpython/tclpython.so.4.1": /usr/lib/tclpython/tclpython.so.4.1: undefined symbol: Py_NoSiteFlag
%


You need to add --libs after `python-config`. So I've not checked but it looks like:

$(tc-getCC) -shared -o tclpython.so.${PV} -fPIC ${CFLAGS} ${LDFGAGS} -Wall -I/usr/include/python${PYVER} tcl{python,thread}.c `python-config --libs` -lpthread -lutil || die

will fix both issues.

Comment 2 Federico Ferri (RETIRED) gentoo-dev

2009-04-16 19:14:23 UTC

In CVS. Thanks Peter ;)