Summary: | media-sound/lastfmplayer calls g++, cc directly | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Steve Dibb (RETIRED) <beandog> |
Component: | New packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hwoarang |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 243502 |
Description
Steve Dibb (RETIRED)
2008-11-13 15:55:18 UTC
Can you explain better what you mean? All I can see on makefiles is this ####### Compiler, tools and options CC = gcc CXX = g++ [snip] .cpp.o: $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<" .cc.o: $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<" Everything looks good to me (In reply to comment #1) > Can you explain better what you mean? All I can see on makefiles is this Please get familiar with toolchain-funcs.eclass. > > ####### Compiler, tools and options > > CC = gcc > CXX = g++ > > [snip] > > > .cpp.o: > $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<" > > .cc.o: > $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<" > > > Everything looks good to me > It's wrong. It should be: CC ?= gcc CXX ?= g++ And after this it would pick the CC and CXX variables from environment, which we could pass by using toolchain-funcs.eclass, and tc-export CC CXX. Right now, the way to fix this something like.. emake CC="$(tc-getCC)" CXX="$(tc-getCXX)" Reason: This will surely break crosscompile/distcc/other special cases. In portage. |