Bug 245534

Summary:	[PATCH] x11-libs/Xaw3d-1.5-r1 can not be emerged on amd64-linux
Product:	Gentoo/Alt	Reporter:	Stefan Hoelldampf <stefan.hoelldampf>
Component:	Prefix Support	Assignee:	Gentoo non-Linux Team <alt>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fixing two Xaw3d issues on amd64-linux

Description Stefan Hoelldampf 2008-11-04 15:37:02 UTC

The following patch fixes two issues in the x11-libs/Xaw3d/Xaw3d-1.5-r1.ebuild for amd64-linux:

1. "xmkmf -DHaveLib64=NO || die" forces the build to use $EPREFIX/usr/lib instead of $EPREFIX/usr/lib64 during installation. I hope the additional define does not cause any problems on platforms other then amd64-linux.

2. The solaris fix introduced -r31747 somehow overrides the SHLIBLDFLAGS value "-shared" of the Makefile on amd64-linux. Thus a shared library can not be created due to the missing "-shared".

Comment 1 Stefan Hoelldampf 2008-11-04 15:39:16 UTC

Created attachment 170719 [details, diff]
Fixing two Xaw3d issues on amd64-linux

Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester

2008-11-04 15:52:59 UTC

(In reply to comment #0)
> The following patch fixes two issues in the x11-libs/Xaw3d/Xaw3d-1.5-r1.ebuild
> for amd64-linux:
> 
> 1. "xmkmf -DHaveLib64=NO || die" forces the build to use $EPREFIX/usr/lib
> instead of $EPREFIX/usr/lib64 during installation. I hope the additional define
> does not cause any problems on platforms other then amd64-linux.

amd64-linux does not and *should not* have usr/lib64/, I thought this was clear by now. =)

> 
> 2. The solaris fix introduced -r31747 somehow overrides the SHLIBLDFLAGS value
> "-shared" of the Makefile on amd64-linux. Thus a shared library can not be
> created due to the missing "-shared".
> 

Ok. Will look into it.

Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester

2008-11-04 15:55:23 UTC

(In reply to comment #2)
> (In reply to comment #0)
> > The following patch fixes two issues in the x11-libs/Xaw3d/Xaw3d-1.5-r1.ebuild
> > for amd64-linux:
> > 
> > 1. "xmkmf -DHaveLib64=NO || die" forces the build to use $EPREFIX/usr/lib
> > instead of $EPREFIX/usr/lib64 during installation. I hope the additional define
> > does not cause any problems on platforms other then amd64-linux.
> 
> amd64-linux does not and *should not* have usr/lib64/, I thought this was clear
> by now. =)

Oh, I read that wrong, I see that you fixed it. I read it as the opposite. Anyway, it won't cause a problem on other prefix installations because we don't do multilib and hence shouldn't have a lib64 anywhere else.

Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester

2008-11-04 17:58:15 UTC

(In reply to comment #1)
> Created an attachment (id=170719) [edit]
> Fixing two Xaw3d issues on amd64-linux
> 

Committed, I just made the xmkmf bit conditional on prefix. thx