Bug 245333 – media-gfx/sam2p-0.45-r1: patch to enable distcc support

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description David Leverton 2008-11-02 22:36:39 UTC]

(Maybe this should be on bug 239671, but I can't reopen that one.  Feel free to mark as a dupe if so.)

The sam2p ebuild currently disables distcc support because it causes the build to fail in the "gmake Makedep" step.  This happens because said step runs a horrible script to parse the warnings in g++ -E output, which are conveniently set up to mention the included header files, on all the source files in order to build Makefile rules with dependencies.  The g++ command exits with an error status, because some of the files include non-existent headers (one is a Windows header that is only used by Windows-specific source files, the other one I'm not quite sure about, but I assume it gets generated later on in the build).  Normally that doesn't cause a problem, because the script ignores the exit status, but it causes distcc to emit an extra error message, confusing the script and causing it to fail.

Therefore, the simplest fix is to modify the script to recognise and ignore the distcc error message.

[Comment 1 David Leverton 2008-11-02 22:37:33 UTC]

Created attachment 170580 [details, diff]
sam2p-0.45-distcc.patch

[Comment 2 Alexis Ballier 2008-11-03 09:34:33 UTC]

Ha! Thanks for tackling this long standing issue. I haven't tried it yet but will probably include it soon; will you mail it to the sam2p author or want me to forward it?

[Comment 3 David Leverton 2008-11-04 19:24:41 UTC]

(In reply to comment #2)
> Ha! Thanks for tackling this long standing issue. I haven't tried it yet but
> will probably include it soon; will you mail it to the sam2p author or want me
> to forward it?
> 

I think I'll be lazy and let you, if you don't mind. ;-)

[Comment 4 Alexis Ballier 2008-11-14 09:20:11 UTC]

merged & mailed to the author, thanks