Bug 243246 – app-cdr/xcdroast request ebuild for 0.98alpha16

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Andrew Hurst 2008-10-22 16:52:23 UTC]

As 0.98alpha16 has been around a while now, I think it's time an ebuild was made for it, and it was made stable.
Not sure what the state of play with cdrtools is: but current ebuild version expects separate cdrecord-prodvd, which has now been merged into cdrtools package

Reproducible: Always

[Comment 1 Andrew Hurst 2008-10-22 21:48:55 UTC]

Having consulted Thomas Niederreiter, the alpha16 release does indeed directly support the merged cdrtools/cdrecord-prodvd.

Not yet sure how many of the other patches are still useful.

[Comment 2 Andrew Hurst 2008-10-23 10:33:10 UTC]

Created attachment 169550 [details]
proposed ebuild

Bare bones ebuild.
dropped all patches: everything except the wodim and icedax support went upstream.
dropped new_configure

[Comment 3 Andrew Hurst 2009-01-26 13:34:29 UTC]

I'm bumping this up to 'normal' priority,
Doesn't seem to have been noticed, the ebuild looks pretty trivial to my mind.
Can anyone comment?

The improvements in the new version are not trivial - full DVD+-RW support via cdrtools.

Can I offer to become xcdroast maintainer if this doesn't go through!?

[Comment 4 Ben Leggett 2009-02-19 22:36:03 UTC]

1. Ebuild specifies a "new_configure" file, which doesn't seem to exist. config script runs fine without it.

2. Compile fails at io.c with error:

io.c: In function 'get_uname_info':
io.c:1906: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result
In function 'open',
    inlined from 'save_text2file' at io.c:4723:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
make[2]: *** [xcdroast-io.o] Error 1
make[2]: Leaving directory `/home/benji/Downloads/xcdroast-0.98alpha16/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/benji/Downloads/xcdroast-0.98alpha16'
make: *** [all] Error 2

[Comment 5 Andrew Hurst 2009-02-20 09:57:04 UTC]

Created attachment 182638 [details]
Tweaked ebuild

Removed new_configure from SRC_URI

[Comment 6 Andrew Hurst 2009-02-20 09:57:47 UTC]

Benji, what arch are you using?
Compiles fine for me on x86-32

[Comment 7 Ben Leggett 2009-02-23 21:50:46 UTC]

Ah, I'm on x86-64. I should have mentioned that.

[Comment 8 Ben Leggett 2009-02-23 21:53:07 UTC]

And the compile error is a different bug, apparently: http://bugs.gentoo.org/show_bug.cgi?id=258752

[Comment 9 Andrew Hurst 2009-02-24 10:09:21 UTC]

Thomas Niederreiter <[e-mail]> produced a patch within about 6 hours of me contacting him! Many thanks Thomas,
the patch can be found here:

http://www.xcdroast.org/xcdr098/patches/io_compile.patch

and I think should go into the ebuild.

Ben, would you like to try it out?

[Comment 10 Ben Leggett 2009-02-25 09:42:59 UTC]

It's a "go", works here.
Compiles with patch and runs fine.

[Comment 11 Patrick Lauer 2009-03-01 23:48:02 UTC]

+  01 Mar 2009; Patrick Lauer <[e-mail]> +files/io_compile.patch,
+  +xcdroast-0.98_alpha16.ebuild:
+  Bump to alpha16. Closes #243246 and #258752

[Comment 12 Manfred Knick 2009-03-19 08:34:24 UTC]

I get an ERRROR even running it as _root_:

# xcdroast

** (xcdroast:12478): WARNING **: Failed to access cdrecord. Please check the permissions and ownership of /usr/bin/cdrecord


# ll /usr/bin/cdrecord
lrwxrwxrwx 1 root root 5 31. Jan 09:01 /usr/bin/cdrecord -> wodim


# ll /usr/bin/wodim
-rwxr-xr-x 1 root root 393K 31. Jan 09:01 /usr/bin/wodim


# grep "cdr" /etc/group
cdrom::19:haldaemon,...
cdrw::80:haldaemon,...

[Comment 13 Manfred Knick 2009-03-19 08:35:28 UTC]

(In reply to comment #12)
> I get an ERRROR even running it as _root_:

Sorry, I forgot to mention:  I'm on amd64 ;)

[Comment 14 Andrew Hurst 2009-03-19 09:41:59 UTC]

Hi Manfred,
yes the cdrkit (wodim) patch got dropped with the alpha16 ebuild, but the patch is still around if you can't bear to use cdrtools.

File a bug if you'd like the cdrkit patch back in?

[Comment 15 Manfred Knick 2009-03-19 13:34:50 UTC]

(In reply to comment #14)

> yes the cdrkit (wodim) patch got dropped with the alpha16 ebuild
That's perfectly o.k. with me ...

> but the patch
> is still around if you can't bear to use cdrtools.
No, 'preference' is not my point, not at all:

Whatever the maintainers exploit / provide under the hood:
*freshly emerging* a package,
the application should _run_ and not _fail_ .

Otherwise, the ebuilds have to be adapted -
be it dependencies, rejections, blockings - 
'what ever it might imply'.

[Comment 16 Andrew Hurst 2009-03-19 16:11:51 UTC]

That's a fair argument:
the problem stems from the 'good idea' to have a virtual for cdrtools/cdrkit when they're not drop-in compatible.

Perhaps the ebuild might reject cdrkit somehow?
Still would be better in a new bug report.

[Comment 17 Manfred Knick 2009-03-19 16:50:31 UTC]

(In reply to comment #16)
...
> Perhaps the ebuild might reject cdrkit somehow?
Sorry if I don't grasp your argument.
IFF xcdroast still needs cdrecord, it should be accessible.
IFF xcdroast now   needs something else, then that should be accessible.

In the new version (ebuild . unpack),
src/xcdroast.h  explicitly defines:

/* this paths can be specified relative to lib-dir or absolute */
/* xcdroast will look for these first in $LIBDIR/ and if not found
   then in $PREFIX (e.g. /usr/bin/cdrecord instead of
   /usr/local/lib/xcdroast-0.98/bin/cdrecord) */

#define CDRECORD "bin/cdrecord"
#define CDDA2WAV "bin/cdda2wav"
#define READCD "bin/readcd"
#define MKISOFS "bin/mkisofs"


Already reported above:
lrwxrwxrwx 1 root root 5 31. Jan 09:01 /usr/bin/cdrecord -> wodim
-rwxr-xr-x 1 root root 393K 31. Jan 09:01 /usr/bin/wodim


> Still would be better in a new bug report.

Here you go:

   http://bugs.gentoo.org/show_bug.cgi?id=263058