Bug 241992 – sys-apps/iproute2: C(XX)FLAGS are ignored (at src_configure/compile)

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Diego Elio Pettenò (RETIRED) 2008-10-14 13:18:53 UTC]

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

[Comment 1 SpanKY 2009-01-17 17:04:04 UTC]

no real information here.  everything looks fine to me.

[Comment 2 Kevin Pyle 2009-01-20 04:04:40 UTC]

Diego, did you misreport this?  As vapier says, user CFLAGS seem to be used.  However, I see some calls to a bare 'gcc' in the build process, which would have triggered your check for packages ignoring CC.  Cursory examination shows that this is via a variable called HOSTCC, which presumably means this is a false positive.  iproute2 builds four executables for the host architecture, which it then runs to produce some data files.  Everything else is compiled with the full ${CHOST}-gcc.