Bug 241982

Summary:	sys-apps/compare: C(XX)FLAGS are ignored (at src_configure/compile)
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	volkmar
Priority:	High	Keywords:	PMASKED
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:	Pending removal 2010-02-14
Package list:		Runtime testing required:	---
Attachments:	Patch that makes CFLAGS, CXXFLAGS and LDFLAGS recognized

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-10-14 13:16:42 UTC

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

Comment 1 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2008-10-16 05:57:03 UTC

Created attachment 168642 [details, diff]
Patch that makes CFLAGS, CXXFLAGS and LDFLAGS recognized

Actually, same type of issue of bug 241984. Fixed the same way.

Btw, I was surprised to see it is blocking imagemagick and I discovered it is for a naming conflict (see bug 117739). Was a renaming impossible ?

Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev

2010-02-17 15:54:30 UTC

Treecleaned.