Bug 241880

Summary:	sys-kernel/gentoo-sources-2.6.27: XFS Barrier support broken
Product:	Gentoo Linux	Reporter:	Toei Rei <gbugs>
Component:	New packages	Assignee:	Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel>
Status:	RESOLVED FIXED
Severity:	critical
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=73f6aa4d44ab6157badc456ddfa05b31e58de5f0
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fix Barrier Fail Detection Patch

Description Toei Rei 2008-10-14 07:16:07 UTC

dmesg shows a message like that:

Filesystem "hda3": xlog_iodone: Barriers are no longer supported by device. Disabling barriers



Reproducible: Always

Steps to Reproduce:
1. format a partition with the XFS Filesystem
2. boot a 2.6.27 kernel
3. dmesg

Actual Results:  
Bug already reported to the xfs team


function xlog_iodone broken. 

If a buffer gets the XBF_ORDERED flag cleared, they assume that barriers are not supported. But this can be the case not only for buffers where the barrier failed, but also the first buffer of a split log write in case of a log wraparound.

Comment 1 Toei Rei 2008-10-14 07:17:42 UTC

Created attachment 168362 [details, diff]
Fix Barrier Fail Detection Patch

This is the patch from the xfs team

Comment 2 Wormo (RETIRED) gentoo-dev

2008-10-15 06:18:43 UTC

Thanks for reporting this bug and its upstream patch -- assigning to maintainers.

Comment 3 Toei Rei 2008-10-15 11:57:13 UTC

Regarding the git-log on kernel.org, the patch is already included as commit 73f6aa4d44ab6157badc456ddfa05b31e58de5f0

See http://www.kernel.org/pub/linux/kernel/v2.6/snapshots/patch-2.6.27-git1.log

Comment 4 Mike Pagano gentoo-dev

2008-10-16 17:29:15 UTC

By the time I do a gentoo-sources-2.6.27-r1, this patch will probably be included from mainline.

I will keep this open in the event I do a new release and it's not in there. But it's highly unlikely, IMO.

Comment 5 Toei Rei 2008-10-17 06:11:07 UTC

Just for your info: 2.6.27.1 was released, having just that e1000 patch. So I guess it will take some more time.

Comment 6 Mike Pagano gentoo-dev

2008-10-23 15:23:49 UTC

Now included in gentoo-sources-2.6.27-r1