Summary: | Automatically symlinking identical GNOME user documentation figure pictures | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mart Raudsepp <leio> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED OBSOLETE | ||
Severity: | enhancement | ||
Priority: | Lowest | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Mart Raudsepp
2008-10-13 00:53:11 UTC
Actually, gnome-doc-utils-0.14 already does this it seems. However not all packages are using this version yet. install-doc-figs: @list='$(patsubst C/%,%,$(_DOC_C_FIGURES))'; for fig in $$list; do \ for lc in C $(_DOC_REAL_LINGUAS); do \ figsymlink=false; \ if test -f "$$lc/$$fig"; then \ figfile="$$lc/$$fig"; \ elif test -f "$(srcdir)/$$lc/$$fig"; then \ figfile="$(srcdir)/$$lc/$$fig"; \ else \ figsymlink=true; \ fi; \ figdir="$$lc/"`echo $$fig | sed -e 's/^\(.*\/\).*/\1/' -e '/\//!s/.*//'`; \ figdir="$(DESTDIR)$(HELP_DIR)/$(DOC_MODULE)/$$figdir"; \ if ! test -d "$$figdir"; then \ echo "$(mkinstalldirs) $$figdir"; \ $(mkinstalldirs) "$$figdir"; \ fi; \ figbase=`echo $$fig | sed -e 's/^.*\///'`; \ if $$figsymlink; then \ echo "cd $$figdir && $(LN_S) -f ../../C/$$fig $$figbase"; \ ( cd "$$figdir" && $(LN_S) -f "../../C/$$fig" "$$figbase" ); \ else \ echo "$(INSTALL_DATA) $$figfile $$figdir$$figbase"; \ $(INSTALL_DATA) "$$figfile" "$$figdir$$figbase"; \ fi; \ done; \ done This code is there since gnome-doc-utils-0.14.1 I think this code works only if the translators haven't added copies of english ones already, doesn't it? Like many packages user doc translations already copy english figures without having them updated, and I don't think those will be killed automatically and replaced with symlinks. Didn't digest through that bash code all that much though. But yeah, the bottom-line is that the mechanisms are there in gnome-doc-utils to do it right, but just packages need to use a new enough version, and possibly delete the figures that are mere identical copies of the C locale (american english) figures. (In reply to comment #2) > This code is there since gnome-doc-utils-0.14.1 > Well, that version is pretty old, how could we see what packages are still using older version than that? (In reply to comment #4) > (In reply to comment #2) > > This code is there since gnome-doc-utils-0.14.1 > > > > Well, that version is pretty old, how could we see what packages are still > using older version than that? What do we need to do related with this problem now that new enough gnome-doc-utils is around for a long time? Thanks I think we can just close this bug as obsolete. |