Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 241668

Summary: Patch for flagedit
Product: Gentoo Linux Reporter: LanoxxthShaddow <sbastig>
Component: Current packagesAssignee: dams (RETIRED) <dams>
Status: RESOLVED TEST-REQUEST    
Severity: normal CC: perl
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description LanoxxthShaddow 2008-10-12 23:29:37 UTC
In Portage 2.2 folders in stead of files are used in /etc/portage/*.keyword.
the following path can fix flagedit to work with the folder structure

Reproducible: Always

Steps to Reproduce:
Apply the following patch:
Filename: flagedit.0.0.7.patch
8,14c8,14
< our $VERSION='0.0.7';
< my $uf_file = '/etc/portage/package.use';
< my $kw_file = '/etc/portage/package.keywords';
< my $mc_file = '/etc/make.conf';
< my $portage_dir = '/usr/portage';
< my $alpha_order = 0;
< my $strict = 0;
---
> our $VERSION='0.0.7.1';
> my $uf_file = (-d '/etc/portage/package.use' ? '/etc/portage/package.use/monolithic' : '/etc/portage/package.use');   #useflag file
> my $kw_file = (-d '/etc/portage/package.keywords' ? '/etc/portage/package.keywords/monolithic' : '/etc/portage/package.keywords');    #keyword file
> my $mc_file = '/etc/make.conf';                               #make.conf file in etc
> my $portage_dir = '/usr/portage';                     #directory where portage is installed
> my $alpha_order = 0;
> my $strict = 0;
then run: sudo patch -p0 < flagedit.0.0.7.patch /usr/bin/flagedit
Actual Results:  
Also described in:
http://gentoo-wiki.com/HOWTO_Use_Portage_Correctly
in section: Package.* Folders
Comment 1 Wormo (RETIRED) gentoo-dev 2008-10-13 02:19:55 UTC
Thanks for submitting this enhancement, assigning to flagedit maintainer who also is the upstream flagedit developer :)

For future patch submissions, please note the "create a new attachment" link in the little table -- that is where proposed patches are meant to go.
Comment 2 LanoxxthShaddow 2008-10-13 18:54:39 UTC
(In reply to comment #1)
> Thanks for submitting this enhancement, assigning to flagedit maintainer who
> also is the upstream flagedit developer :)
> 
> For future patch submissions, please note the "create a new attachment" link in
> the little table -- that is where proposed patches are meant to go.
> 

I found another bug: flagedit saves a copy of the old files with .old filename extention, however with the new *.package folders structure all files in the respective folders are sourced, thus making the user to issue each command twice to ensure that a given flag is fully removed. for adding this doesnt matter of course, so the bug is not very obvious in the first place.
I dont really know enough perl to fix this, but the solution would be no to create the .old backups if the *.package structure is found, or store them at another place that is not sourced by eix/portage.

best regards
Comment 3 dams (RETIRED) gentoo-dev 2009-01-16 23:42:30 UTC
New version flagedit-0.0.8 should implement that feature.
Let me know of any bug.