Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 241488

Summary: x11-misc/xrootconsole: pre-stripped files found
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Desktop Misc. Team <desktop-misc>
Severity: QA CC: jer
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 239866    
Attachments: Patch to address QA issues in Makefile
Patch to ebuild to apply attachment #194067 and to make with CC=$(tc-getCC)

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-10-12 00:02:06 UTC
Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-23 19:55:24 UTC
*** Bug 252106 has been marked as a duplicate of this bug. ***
Comment 2 Kevin Pyle 2009-06-10 02:56:52 UTC
Created attachment 194067 [details, diff]
Patch to address QA issues in Makefile

This patch resolves several QA issues with the upstream Makefile:

- CC forced to gcc.
- CPPFLAGS overwritten with an empty value.
- CFLAGS overwritten with -O2.
- LDFLAGS overwritten with -s, causing premature stripping.

For my convenience during testing, this was written as a second patch to be applied after the existing Gentoo patch to the upstream Makefile.  Maintainers, you are welcome to merge this patch with the other or leave it separate, as you prefer.  I will attach an ebuild patch that assumes it is left separate.
Comment 3 Kevin Pyle 2009-06-10 02:58:36 UTC
Created attachment 194068 [details, diff]
Patch to ebuild to apply attachment #194067 [details, diff] and to make with CC=$(tc-getCC)
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-08 11:11:34 UTC
Fixed in 0.6 without revision bump.