Summary: | x11-misc/xrootconsole: pre-stripped files found | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Desktop Misc. Team <desktop-misc> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | jer |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 239866 | ||
Attachments: |
Patch to address QA issues in Makefile
Patch to ebuild to apply attachment #194067 and to make with CC=$(tc-getCC) |
Description
Diego Elio Pettenò (RETIRED)
2008-10-12 00:02:06 UTC
*** Bug 252106 has been marked as a duplicate of this bug. *** Created attachment 194067 [details, diff]
Patch to address QA issues in Makefile
This patch resolves several QA issues with the upstream Makefile:
- CC forced to gcc.
- CPPFLAGS overwritten with an empty value.
- CFLAGS overwritten with -O2.
- LDFLAGS overwritten with -s, causing premature stripping.
For my convenience during testing, this was written as a second patch to be applied after the existing Gentoo patch to the upstream Makefile. Maintainers, you are welcome to merge this patch with the other or leave it separate, as you prefer. I will attach an ebuild patch that assumes it is left separate.
Created attachment 194068 [details, diff] Patch to ebuild to apply attachment #194067 [details, diff] and to make with CC=$(tc-getCC) Fixed in 0.6 without revision bump. |