Bug 241038

Summary:	net-mail/altermime: C(XX)FLAGS are ignored (at src_configure/compile)
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Net-Mail Packages <net-mail+disabled>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kfm, patrick
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	altermime-0.3.10-respect-flags.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-10-10 11:13:02 UTC

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

Comment 1 kfm 2010-10-07 23:44:10 UTC

As this is a trivial case with infrequent releases from upstream, let's just use a patch.

Comment 2 kfm 2010-10-07 23:44:23 UTC

Created attachment 249898 [details, diff]
altermime-0.3.10-respect-flags.patch

Comment 3 Patrick Lauer gentoo-dev

2010-11-02 19:02:38 UTC

+  02 Nov 2010; Patrick Lauer <patrick@gentoo.org>
+  +altermime-0.3.10-r1.ebuild, +files/altermime-0.3.10-respect-flags.patch:
+  Fixes for #241038, thanks to Kerin Millar