Bug 240894

Summary:	net-ftp/linksys-tftp: C(XX)FLAGS are ignored (at src_configure/compile)
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Embedded Gentoo Team <embedded>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-10-09 22:05:34 UTC

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

Comment 1 Michael Weber (RETIRED) gentoo-dev

2010-10-04 15:59:27 UTC

+*linksys-tftp-1.2.1-r1 (03 Oct 2010)
+
+  03 Oct 2010; Michael Weber <xmw@gentoo.org> linksys-tftp-1.2.1.ebuild,
+  +linksys-tftp-1.2.1-r1.ebuild,
+  +files/linksys-tftp-1.2.1-r1-Makefile.patch,
+  +files/linksys-tftp-1.2.1-r1-header.patch:
+  Revbump to fix CFLAGS (bug 240894) and LDFLAGS (bug 336956)
+