Bug 240860 – net-analyzer/nbaudit: C(XX)FLAGS are ignored (at src_configure/compile)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2008-10-09 21:55:24 UTC]

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

[Comment 1 Jeroen Roovers (RETIRED) 2010-09-02 18:02:06 UTC]

In -r2, I removed the line saying it segfaults when built with CFLAGS other than none, because it segfaults regardless of how it is compiled. Even filtering specific CFLAGS does not prevent segfaulting. Also, setting -Wall in CFLAGS reveals a couple some quite bad coding errors.